From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Date: Wed, 17 Jul 2019 02:28:30 +0000 Subject: Re: [PATCH V4 1/9] block: add a helper function to read nr_setcs Message-Id: List-Id: References: <20190708184711.2984-1-chaitanya.kulkarni@wdc.com> <20190708184711.2984-2-chaitanya.kulkarni@wdc.com> In-Reply-To: (Chaitanya Kulkarni's message of "Fri, 12 Jul 2019 16:09:56 +0000") MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chaitanya Kulkarni Cc: "Martin K. Petersen" , "linux-block@vger.kernel.org" , "colyli@suse.de" , "linux-bcache@vger.kernel.org" , "linux-btrace@vger.kernel.org" , "xen-devel@lists.xenproject.org" , "kent.overstreet@gmail.com" , "yuchao0@huawei.com" , "jaegeuk@kernel.org" , Damien Le Moal , "konrad.wilk@oracle.com" , "roger.pau@citrix.com" , "bvanassche@acm.org" , "linux-scsi@vger.kernel.org" Chaitanya, > This series just replaces the existing accesses without changing > anything. > > So if any of the exiting code has that bug then it will blow up > nicely. > > For future callers I don't mind adding a new check and resend the > series. > > Would you prefer adding a check ? I checked your call sites and they look fine. Also, I don't think returning a capacity of 0 on error is going to help us much. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering