linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Lei <zhaolei@cn.fujitsu.com>
To: "'David Sterba'" <dsterba@suse.cz>
Cc: "'btrfs'" <linux-btrfs@vger.kernel.org>
Subject: test fail for btrfs: synchronize incompat feature bits with sysfs files
Date: Wed, 27 Jan 2016 14:57:18 +0800	[thread overview]
Message-ID: <003501d158cf$f71750f0$e545f2d0$@cn.fujitsu.com> (raw)

Hi, David Sterba

I find this patch caused NULL pointer accessing in lattest integration-4.5:
  btrfs: synchronize incompat feature bits with sysfs files
  CommitID: 14e46e04958df740c6c6a94849f176159a333f13

Several xfstests(as btrfs/103) failed with "BUG: unable to handle kernel NULL pointer..." warning.
Can be reproduced by following way:
  mkfs.btrfs -f /dev/sdb20
  mount -o "compress=lzo" /dev/sdb20 /mnt/tmp
  (panic)

Maybe caused by following reason:
(Only guessd by review source, hadn't trace to confirm)
 In open_ctree(), btrfs_parse_options()->btrfs_sysfs_feature_update()->sysfs_remove_group()
 is trying to remove fs_info->fs_devices->fsid_kobj, but this kobject is not initialized before.
 It is initialized in open_ctree() after btrfs_parse_options().

Cound you try to confirm it?

Thanks
Zhaolei





             reply	other threads:[~2016-01-27  6:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-27  6:57 Zhao Lei [this message]
2016-01-27  8:48 ` test fail for btrfs: synchronize incompat feature bits with sysfs files David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='003501d158cf$f71750f0$e545f2d0$@cn.fujitsu.com' \
    --to=zhaolei@cn.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).