linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Zhao Lei <zhaolei@cn.fujitsu.com>
To: <fdmanana@gmail.com>
Cc: <linux-btrfs@vger.kernel.org>
Subject: RE: [PATCH 2/2] btrfs: Set hole_size to free space in case of contains_pending_extent
Date: Fri, 6 Feb 2015 18:52:52 +0800	[thread overview]
Message-ID: <006101d041fb$0e768730$2b639590$@cn.fujitsu.com> (raw)
In-Reply-To: <CAL3q7H61kG20B66wKd52bbks2dYgsikst__kq+dzOG-jOAKXvw@mail.gmail.com>

Hi, Filipe
 
> This was already fixed by Forrest recently. See:
> https://patchwork.kernel.org/patch/5776231/
> 
Thanks for notice, I overlooked the second half of his patch...
Please ignore it.

Thanks
Zhaolei

> > ---
> >  fs/btrfs/volumes.c | 8 ++++++--
> >  1 file changed, 6 insertions(+), 2 deletions(-)
> >
> > diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> > index 5cd0930..0cc9422 100644
> > --- a/fs/btrfs/volumes.c
> > +++ b/fs/btrfs/volumes.c
> > @@ -1194,8 +1194,12 @@ again:
> >                          */
> >                         if (contains_pending_extent(trans, device,
> >                                                     &search_start,
> > -                                                   hole_size))
> > -                               hole_size = 0;
> > +                                                   hole_size)) {
> > +                               if (search_start > key.offset)
> > +                                       hole_size = 0;
> > +                               else
> > +                                       hole_size = key.offset - search_start;
> > +                       }
> >
> >                         if (hole_size > max_hole_size) {
> >                                 max_hole_start = search_start;
> > --
> > 1.8.5.1
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 
> --
> Filipe David Manana,
> 
> "Reasonable men adapt themselves to the world.
>  Unreasonable men adapt the world to themselves.
>  That's why all progress depends on unreasonable men."



      reply	other threads:[~2015-02-06 10:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06  8:42 [PATCH 0/2] btrfs: Fix out-of-space bug Zhaolei
2015-02-06  8:42 ` [PATCH 1/2] btrfs: Fix out-of-space bug caused by searching commit_root in find_free_dev_extent() Zhaolei
2015-02-06  9:54   ` Filipe David Manana
2015-02-06 10:50     ` Zhao Lei
2015-02-06  8:42 ` [PATCH 2/2] btrfs: Set hole_size to free space in case of contains_pending_extent Zhaolei
2015-02-06  9:56   ` Filipe David Manana
2015-02-06 10:52     ` Zhao Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='006101d041fb$0e768730$2b639590$@cn.fujitsu.com' \
    --to=zhaolei@cn.fujitsu.com \
    --cc=fdmanana@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).