* re: btrfs: reada: simplify dev->reada_in_flight processing
@ 2016-02-17 19:01 Dan Carpenter
2016-02-18 1:37 ` Zhao Lei
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2016-02-17 19:01 UTC (permalink / raw)
To: zhaolei; +Cc: linux-btrfs
Hello Zhao Lei,
The patch 7aff519c04d2: "btrfs: reada: simplify dev->reada_in_flight
processing" from Jan 12, 2016, leads to the following static checker
warning:
fs/btrfs/reada.c:697 reada_start_machine_dev()
warn: inconsistent indenting
fs/btrfs/reada.c
688 spin_unlock(&fs_info->reada_lock);
689 return 0;
690 }
691 dev->reada_next = re->logical + fs_info->tree_root->nodesize;
692 re->refcnt++;
693
694 spin_unlock(&fs_info->reada_lock);
695
696 spin_lock(&re->lock);
697 if (re->scheduled || list_empty(&re->extctl)) {
This is indented too much.
698 spin_unlock(&re->lock);
699 reada_extent_put(fs_info, re);
700 return 0;
701 }
702 re->scheduled = 1;
703 spin_unlock(&re->lock);
704
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: btrfs: reada: simplify dev->reada_in_flight processing
2016-02-17 19:01 btrfs: reada: simplify dev->reada_in_flight processing Dan Carpenter
@ 2016-02-18 1:37 ` Zhao Lei
2016-02-18 9:39 ` David Sterba
0 siblings, 1 reply; 3+ messages in thread
From: Zhao Lei @ 2016-02-18 1:37 UTC (permalink / raw)
To: 'Dan Carpenter'; +Cc: linux-btrfs, 'David Sterba'
Hi, Dan Carpenter
> From: Dan Carpenter [mailto:dan.carpenter@oracle.com]
> Sent: Thursday, February 18, 2016 3:02 AM
> To: zhaolei@cn.fujitsu.com
> Cc: linux-btrfs@vger.kernel.org
> Subject: re: btrfs: reada: simplify dev->reada_in_flight processing
>
> Hello Zhao Lei,
>
> The patch 7aff519c04d2: "btrfs: reada: simplify dev->reada_in_flight
> processing" from Jan 12, 2016, leads to the following static checker
> warning:
>
> fs/btrfs/reada.c:697 reada_start_machine_dev()
> warn: inconsistent indenting
>
> fs/btrfs/reada.c
> 688 spin_unlock(&fs_info->reada_lock);
> 689 return 0;
> 690 }
> 691 dev->reada_next = re->logical +
> fs_info->tree_root->nodesize;
> 692 re->refcnt++;
> 693
> 694 spin_unlock(&fs_info->reada_lock);
> 695
> 696 spin_lock(&re->lock);
> 697 if (re->scheduled || list_empty(&re->extctl)) {
>
> This is indented too much.
>
Thanks for report.
This problem is introduced in patch titled:
btrfs: reada: Move is_need_to_readahead contition earlier
I'll fix it.
CC: David Sterba <dsterba@suse.cz>
I'll fix this indent problem in following branch:
https://github.com/zhaoleidd/btrfs.git integration-4.5
Could you pick them again?
Thanks
Zhaolei
> 698 spin_unlock(&re->lock);
> 699 reada_extent_put(fs_info, re);
> 700 return 0;
> 701 }
> 702 re->scheduled = 1;
> 703 spin_unlock(&re->lock);
> 704
>
> regards,
> dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: btrfs: reada: simplify dev->reada_in_flight processing
2016-02-18 1:37 ` Zhao Lei
@ 2016-02-18 9:39 ` David Sterba
0 siblings, 0 replies; 3+ messages in thread
From: David Sterba @ 2016-02-18 9:39 UTC (permalink / raw)
To: Zhao Lei; +Cc: 'Dan Carpenter', linux-btrfs, 'David Sterba'
On Thu, Feb 18, 2016 at 09:37:41AM +0800, Zhao Lei wrote:
> CC: David Sterba <dsterba@suse.cz>
> I'll fix this indent problem in following branch:
> https://github.com/zhaoleidd/btrfs.git integration-4.5
>
> Could you pick them again?
Done, fixed manually and updated in for-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-02-18 9:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-17 19:01 btrfs: reada: simplify dev->reada_in_flight processing Dan Carpenter
2016-02-18 1:37 ` Zhao Lei
2016-02-18 9:39 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).