From: JP Kobryn <inwardvessel@gmail.com>
To: Matthew Wilcox <willy@infradead.org>, Qu Wenruo <quwenruo.btrfs@gmx.com>
Cc: boris@bur.io, clm@fb.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC PATCH] btrfs: defer freeing of subpage private state to free_folio
Date: Fri, 30 Jan 2026 09:10:11 -0800 [thread overview]
Message-ID: <00d098da-0d01-43f9-9efb-c18b6e8a771e@gmail.com> (raw)
In-Reply-To: <aXw-MiQWyYtZ3brh@casper.infradead.org>
On 1/29/26 9:14 PM, Matthew Wilcox wrote:
> On Fri, Jan 30, 2026 at 01:46:59PM +1030, Qu Wenruo wrote:
>> Another question is, why only two fses (nfs for dir inode, and orangefs) are
>> utilizing the free_folio() callback.
>
> Alas, secretmem and guest_memfd are also using it. Nevertheless, I'm
> not a fan of this interface existing, and would prefer to not introduce
> new users. Like launder_folio, which btrfs has also mistakenly used.
>
The part that felt concerning is how the private state is lost. If
release_folio() frees this state but the folio persists in the cache,
users of the folio afterward have to recreate the state. Is that the
expectation on how filesystems should handle this situation?
In the case of the existing btrfs code, when the state is recreated (in
subpage mode), the bitmap data and lock states are all zeroed.
next prev parent reply other threads:[~2026-01-30 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 23:08 [RFC PATCH] btrfs: defer freeing of subpage private state to free_folio JP Kobryn
2026-01-30 3:16 ` Qu Wenruo
2026-01-30 5:14 ` Matthew Wilcox
2026-01-30 6:28 ` Boris Burkov
2026-01-30 17:10 ` JP Kobryn [this message]
2026-01-30 18:23 ` Matthew Wilcox
2026-01-30 20:36 ` Qu Wenruo
2026-01-31 1:31 ` JP Kobryn
2026-01-30 6:34 ` Boris Burkov
2026-01-30 7:29 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00d098da-0d01-43f9-9efb-c18b6e8a771e@gmail.com \
--to=inwardvessel@gmail.com \
--cc=boris@bur.io \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=kernel-team@meta.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quwenruo.btrfs@gmx.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox