From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: Josef Bacik <josef@toxicpanda.com>, Qu Wenruo <wqu@suse.com>,
linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/3] btrfs: relocation: Remove the open-coded goto loop for breadth-first search
Date: Fri, 28 Feb 2020 08:08:20 +0800 [thread overview]
Message-ID: <013d9b26-d7b8-bc81-6d5b-1585924af4df@gmx.com> (raw)
In-Reply-To: <72797bb0-b20c-3e80-6a15-131e33c9bd26@toxicpanda.com>
[-- Attachment #1.1: Type: text/plain, Size: 925 bytes --]
On 2020/2/28 上午3:51, Josef Bacik wrote:
> On 2/24/20 1:02 AM, Qu Wenruo wrote:
>> build_backref_tree() uses "goto again;" to implement a breadth-first
>> search to build backref cache.
>>
>> This patch will extract most of its work into a wrapper,
>> handle_one_tree_block(), and use a while() loop to implement the same
>> thing.
>>
>> Signed-off-by: Qu Wenruo <wqu@suse.com>
>
> Do you have this in a tree somewhere that I can look at it? I tried
> applying these but they don't apply cleanly to anything I have, and it's
> hard to review this one without seeing how the code ends up after your
> diff. Thanks,
Sure, here you go:
https://github.com/adam900710/linux/tree/backref_cache_new
But please ignore the latest 1 or 2 commits, as they are still under
development.
Every submitted patches will not undergo any extra modification in that
branch.
Thanks,
Qu
>
> Josef
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-02-28 0:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 6:01 [PATCH 0/3] btrfs: relocation: build_backref_cache() refactor part 2 Qu Wenruo
2020-02-24 6:01 ` [PATCH 1/3] btrfs: relocation: Use wrapper to replace open-coded edge linking Qu Wenruo
2020-02-27 19:39 ` Josef Bacik
2020-02-24 6:01 ` [PATCH 2/3] btrfs: relocation: Specify essential members for alloc_backref_node() Qu Wenruo
2020-02-27 19:40 ` Josef Bacik
2020-02-24 6:02 ` [PATCH 3/3] btrfs: relocation: Remove the open-coded goto loop for breadth-first search Qu Wenruo
2020-02-27 19:51 ` Josef Bacik
2020-02-28 0:08 ` Qu Wenruo [this message]
2020-02-28 0:15 ` Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=013d9b26-d7b8-bc81-6d5b-1585924af4df@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox