From: Nikolay Borisov <nborisov@suse.com>
To: Qu Wenruo <quwenruo.btrfs@gmx.com>, Kangjie Lu <kjlu@umn.edu>
Cc: pakki001@umn.edu, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix a NULL pointer dereference
Date: Thu, 14 Mar 2019 11:18:44 +0200 [thread overview]
Message-ID: <01a43691-156b-4750-b070-07cb73fc3c8b@suse.com> (raw)
In-Reply-To: <641736e8-6965-16c6-5b2e-2474d6b72616@gmx.com>
On 14.03.19 г. 11:15 ч., Qu Wenruo wrote:
> Isn't assert() a bad idea for production build without assert() support?
As already discussed this is invariant of the code, if this invariant is
broken then in production builds we'd likely crash (which is good since
we want to understand why and not silently handle it). In debug builds
the assert will be triggered.
next prev parent reply other threads:[~2019-03-14 9:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 7:50 [PATCH] btrfs: fix a NULL pointer dereference Kangjie Lu
2019-03-14 7:54 ` Nikolay Borisov
2019-03-14 8:02 ` Qu Wenruo
2019-03-14 8:03 ` Nikolay Borisov
2019-03-14 8:13 ` [PATCH v2] " Kangjie Lu
2019-03-14 8:16 ` Nikolay Borisov
2019-03-14 9:15 ` [PATCH] " Qu Wenruo
2019-03-14 9:18 ` Nikolay Borisov [this message]
2019-03-14 15:26 ` Kangjie Lu
2019-03-14 10:23 ` Su Yue
2019-03-14 15:41 ` Josef Bacik
2019-03-14 7:59 ` Qu Wenruo
2019-03-25 16:35 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01a43691-156b-4750-b070-07cb73fc3c8b@suse.com \
--to=nborisov@suse.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=josef@toxicpanda.com \
--cc=kjlu@umn.edu \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).