From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 3/4] btrfs: open code btrfs_set_prop in inherit_prop
Date: Thu, 14 Mar 2019 17:08:54 +0800 [thread overview]
Message-ID: <02796a8f-5e37-3295-bd93-805fce46ccb5@oracle.com> (raw)
In-Reply-To: <b31f898f-e561-326f-733c-25d92f549009@suse.com>
On 3/14/19 4:57 PM, Nikolay Borisov wrote:
>
>
> On 14.03.19 г. 7:05 ч., Anand Jain wrote:
>> When an inode inherits property from its parent, we call btrfs_set_prop().
>> btrfs_set_prop() does an elaborate checks, which is not required in the
>> context of inheriting a property. Instead just open-code only the required
>> items from btrfs_set_prop() and then call btrfs_setxattr() directly. So
>> now the only user of btrfs_set_prop() is gone, (except for the wraper
>> function btrfs_set_prop_trans()).
>
> Um, no:
>
> git grep -P '(?<!__)btrfs_set_prop' fs/btrfs/
> fs/btrfs/ioctl.c: ret = btrfs_set_prop(inode, "btrfs.compression", NULL, 0, 0);
> fs/btrfs/ioctl.c: ret = btrfs_set_prop(inode, "btrfs.compression",
> fs/btrfs/ioctl.c: ret = btrfs_set_prop(inode, "btrfs.compression", NULL, 0, 0);
> fs/btrfs/props.c:int btrfs_set_prop(struct inode *inode,
> fs/btrfs/props.h:int btrfs_set_prop(struct inode *inode,
> fs/btrfs/xattr.c: return btrfs_set_prop(inode, name, value, size, flags);
>
>
> Rebase the patch on misc-next and remove the last sentence
> since it's factually wrong.
Oh. This is based on misc-5.2.
Oops I should have mentioned.
Thanks. Anand
next prev parent reply other threads:[~2019-03-14 9:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 5:05 [PATCH 0/4] btrfs: fix property bugs Anand Jain
2019-03-14 5:05 ` [PATCH 1/4] btrfs: fix zstd compression parameter Anand Jain
2019-03-14 5:05 ` [PATCH 2/4] btrfs: fix vanished compression property after failed set Anand Jain
2019-03-14 8:32 ` Nikolay Borisov
2019-03-14 8:57 ` Anand Jain
2019-03-14 5:05 ` [PATCH 3/4] btrfs: open code btrfs_set_prop in inherit_prop Anand Jain
2019-03-14 8:57 ` Nikolay Borisov
2019-03-14 9:08 ` Anand Jain [this message]
2019-03-14 5:05 ` [PATCH 4/4] btrfs: fix property validate fail should not increment generation Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02796a8f-5e37-3295-bd93-805fce46ccb5@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).