From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: dsterba@suse.cz, Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 0/3] btrfs-progs: Split lowmem mode check to its own
Date: Fri, 2 Feb 2018 09:36:54 +0800 [thread overview]
Message-ID: <02cbb5ec-e3a0-96ba-41c0-a08e4a8c1a7b@gmx.com> (raw)
In-Reply-To: <20180201160527.GL18553@twin.jikos.cz>
[-- Attachment #1.1: Type: text/plain, Size: 1278 bytes --]
On 2018年02月02日 00:05, David Sterba wrote:
> On Thu, Feb 01, 2018 at 02:45:38PM +0800, Qu Wenruo wrote:
>> As usual, the main part is over 500K so the biggest patch won't reach
>> mail list.
>> Please fetch the whole branch from github:
>> https://github.com/adam900710/btrfs-progs/tree/split_check
>
> Thanks, patches added to devel, with some more adjustments.
>
>> Despite the update, a new patch is introduced, to address the tons of
>> BORING errors and warning from checkpatch.pl.
>
> The checkpatch script can report lots of things to fix, but please note
> that not all of them match the style we use. I've updated the patch 3/3
> and undone some of the line splits, because it's the example where the
> code looks worse after fixing.
Yep, some 81/82 chars modification is not that elegant.
>
> We'd probably have to host our modified version of checkpatch so the
> warnings don't get reported repeatedly.
That would be the best case, I could take some spare time to port
checkpatch to btrfs-progs.
Thanks,
Qu
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 520 bytes --]
prev parent reply other threads:[~2018-02-02 1:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 6:45 [PATCH v2 0/3] btrfs-progs: Split lowmem mode check to its own Qu Wenruo
2018-02-01 6:45 ` [PATCH v2 2/3] btrfs-progs: check/lowmem: Cleanup unnecessary _v2 suffix Qu Wenruo
2018-02-01 6:45 ` [PATCH v2 3/3] btrfs-progs: check: Cleanup all checkpatch error and warning Qu Wenruo
2018-02-01 7:08 ` Su Yue
2018-02-01 7:48 ` Qu Wenruo
2018-02-01 8:28 ` Nikolay Borisov
2018-02-01 15:06 ` David Sterba
2018-02-01 8:36 ` Nikolay Borisov
2018-02-01 9:20 ` Qu Wenruo
2018-02-01 16:05 ` [PATCH v2 0/3] btrfs-progs: Split lowmem mode check to its own David Sterba
2018-02-02 1:36 ` Qu Wenruo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02cbb5ec-e3a0-96ba-41c0-a08e4a8c1a7b@gmx.com \
--to=quwenruo.btrfs@gmx.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).