public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: louis@waffle.tech
To: "Nikolay Borisov" <nborisov@suse.com>,
	"Wang Yugui" <wangyugui@e16-tech.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: balance RAID1/RAID10 mirror selection
Date: Mon, 02 Nov 2020 19:29:04 +0000	[thread overview]
Message-ID: <041d24ef26dc5c763c5af6d6de7434ef@waffle.tech> (raw)
In-Reply-To: <d4d600aa-a56b-2458-f504-afbb584f888b@suse.com>

Good points. I'll move it into 'struct btrfs_fs_info', look at making it a per-cpu variable, and do some testing with perf (later this week hopefully).

Louis

October 23, 2020 1:42 AM, "Nikolay Borisov" <nborisov@suse.com> wrote:

> On 23.10.20 г. 10:38 ч., Wang Yugui wrote:
> 
>> Hi, Louis Jencka
>> 
>> Can we move 'atomic_t rr_counter' into 'struct btrfs_fs_info' to
>> support multiple mounted btrfs filesystem?
> 
> And introduce constant cache line pings for every read. This thing needs
> to be tested under load with perf to see what kind of overhead the
> shared atomic_t counter adds. My hunch is this should really be a
> per-cpu variable.
> 
> <snip>

  reply	other threads:[~2020-11-02 19:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-16  5:59 [PATCH] btrfs: balance RAID1/RAID10 mirror selection louis
2020-10-16  7:15 ` Nikolay Borisov
2020-10-16  7:29   ` Qu Wenruo
2020-10-16 17:28     ` louis
2020-10-18  8:16       ` Anand Jain
2020-10-16 16:18   ` louis
2020-10-16 17:21 ` waxhead
2020-10-23  7:38 ` Wang Yugui
2020-10-23  7:42   ` Nikolay Borisov
2020-11-02 19:29     ` louis [this message]
2020-11-02 19:36       ` louis
2020-10-27 14:26   ` Wang Yugui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=041d24ef26dc5c763c5af6d6de7434ef@waffle.tech \
    --to=louis@waffle.tech \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=nborisov@suse.com \
    --cc=wangyugui@e16-tech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox