Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Nikolay Borisov <nborisov@suse.com>
To: Johannes Thumshirn <jthumshirn@suse.de>, David Sterba <dsterba@suse.com>
Cc: Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH] btrfs: remove btrfs_bio_end_io_t
Date: Fri, 23 Nov 2018 10:45:03 +0200	[thread overview]
Message-ID: <063bcdf0-ccde-c7ff-b6bb-31d0aff05ed5@suse.com> (raw)
In-Reply-To: <20181123084227.25840-1-jthumshirn@suse.de>



On 23.11.18 г. 10:42 ч., Johannes Thumshirn wrote:
> The btrfs_bio_end_io_t typedef was introduced with commit
> a1d3c4786a4b ("btrfs: btrfs_multi_bio replaced with btrfs_bio")
> but never used anywhere. This commit also introduced a forward declaration
> of 'struct btrfs_bio' which is only needed for btrfs_bio_end_io_t.
> 
> Remove both as they're not needed anywhere.
> 
> Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de>

Reviewed-by: Nikolay Borisov <nborisov@suse.com>

> ---
>  fs/btrfs/volumes.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
> index 8b092bb1e2ee..c93097b0b469 100644
> --- a/fs/btrfs/volumes.h
> +++ b/fs/btrfs/volumes.h
> @@ -295,9 +295,6 @@ struct btrfs_bio_stripe {
>  	u64 length; /* only used for discard mappings */
>  };
>  
> -struct btrfs_bio;
> -typedef void (btrfs_bio_end_io_t) (struct btrfs_bio *bio, int err);
> -
>  struct btrfs_bio {
>  	refcount_t refs;
>  	atomic_t stripes_pending;
> 

  reply	other threads:[~2018-11-23  8:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-23  8:42 [PATCH] btrfs: remove btrfs_bio_end_io_t Johannes Thumshirn
2018-11-23  8:45 ` Nikolay Borisov [this message]
2018-11-23 12:40 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=063bcdf0-ccde-c7ff-b6bb-31d0aff05ed5@suse.com \
    --to=nborisov@suse.com \
    --cc=dsterba@suse.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox