From: Anand Jain <anand.jain@oracle.com>
To: Nikolay Borisov <nborisov@suse.com>,
dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH v2 1/2] btrfs: match btrfs_device->mode same as it used for open
Date: Thu, 2 Nov 2017 13:55:46 +0800 [thread overview]
Message-ID: <069ca762-6e7a-ff41-44ae-ff1db44e40d8@oracle.com> (raw)
In-Reply-To: <fb901ef0-d4ee-66e8-c8ba-2736d856a5ca@suse.com>
On 10/31/2017 10:21 PM, Nikolay Borisov wrote:
>
>
> On 31.10.2017 04:11, Anand Jain wrote:
>>
>>
>> On 10/30/2017 10:39 PM, David Sterba wrote:
>>> On Fri, Oct 20, 2017 at 10:07:15PM +0800, Anand Jain wrote:
>>>> We aren't setting the FMODE_WRITE when initializing btrfs_device
>>>> structure and when calling blkdev_put, however we are setting it
>>>> only when calling blkdev_get_by_path().
>>>
>>> But this still does not say why this is a problem worth fixing. Nikolay
>>> asked for it, and I would do the same, but why do we even have to ask
>>> for that?
>>
>> Here its just a cleanup of miss match of open mode and close modes.> And there isn't any problem that I noticed.
>
> Even if that's the case, please state that explicitly in your changelog
> and also put "No functional changes" if you expect it to not introduce
> any change in behavior.
>
Ah. Will update change log.
Thanks, Anand
>>
>> Thanks, Anand
>>
>>
>>> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-11-02 5:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 10:33 [PATCH 1/2] btrfs: match btrfs_device->mode same as it used for open Anand Jain
2017-10-20 10:33 ` [PATCH 2/2] btrfs: maintain consistent fmode flags for device open Anand Jain
2017-10-20 12:26 ` [PATCH 1/2] btrfs: match btrfs_device->mode same as it used for open Nikolay Borisov
2017-10-20 14:00 ` Anand Jain
2017-10-20 14:07 ` [PATCH v2 " Anand Jain
2017-10-30 14:39 ` David Sterba
2017-10-31 2:11 ` Anand Jain
2017-10-31 14:21 ` Nikolay Borisov
2017-11-02 5:55 ` Anand Jain [this message]
2017-11-02 6:11 ` [PATCH v3 " Anand Jain
2017-11-02 8:47 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=069ca762-6e7a-ff41-44ae-ff1db44e40d8@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).