Re: [PATCH 4/4] btrfs-progs: test btrfstune -m|M ability to fix previous failures

[Anand Jain <anand.jain@oracle.com>]

On 3/10/23 16:00, Anand Jain wrote:
> 
> 
> On 3/10/23 01:19, David Sterba wrote:
>> On Fri, Sep 15, 2023 at 12:08:59PM +0800, Anand Jain wrote:
>>> The misc-test/034-metadata_uuid test case, has four sets of disk 
>>> images to
>>> simulate failed writes during btrfstune -m|M operations. As of now, this
>>> tests kernel only. Update the test case to verify btrfstune -m|M's
>>> capacity to recover from the same scenarios.
>>>
>>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>>
>> With all the problems fixed, the test still fails.  I'm not sure which 
>> case it
>> is:
>>
>> ====== RUN CHECK root_helper losetup --find --show ./disk1.raw.restored
>> /dev/loop0
>> ====== RUN CHECK root_helper losetup --find --show ./disk2.raw.restored
>> /dev/loop1
>> ====== RUN CHECK root_helper udevadm settle
>> ====== RUN CHECK root_helper /labs/dsterba/gits/btrfs-progs/btrfstune 
>> -m /dev/loop1
>> parent transid verify failed on 30425088 wanted 6 found 4
>> parent transid verify failed on 30441472 wanted 6 found 4
>> Error writing to device 1
>> ERROR: failed to write tree block 30457856: Operation not permitted
>> ERROR: btrfstune failed
>> failed: root_helper /labs/dsterba/gits/btrfs-progs/btrfstune -m 
>> /dev/loop1
>> test failed for case 034-metadata-uuid
>>
>> Looks like a write that's beyond the device limit. I'll keep the patches
>> and tests in devel so you can have a look.
> 
> 
> As a root user, your devel branch passes here.
> 
> (Generally, I have been using the following command as root:)
> 
>   $ make TEST=034* test-misc
>   [LD] fssum
>   [LD] fsstress
>   [TEST] misc-tests.sh
>   [TEST/misc] 034-metadata-uuid
>   Scanning /btrfs-progs/tests/misc-tests-results.txt
> 
> Let me try as a non-root user.
> 
> Also, could you please make sure that all the 
> 'tests/misc-tests/034-metadata-uuid/*.restored' files are removed before 
> starting the test case?

This pass as non-root.

$ sudo make TEST=034* test-misc
     [LD]     fssum
     [LD]     fsstress
     [TEST]   misc-tests.sh
     [TEST/misc]   034-metadata-uuid
Scanning /btrfs-progs/tests/misc-tests-results.txt

So I think there might be some stale *restored images; Could you pls check.

Thanks, Anand