From: Anand Jain <anand.jain@oracle.com>
To: dsterba@suse.cz, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 2/2] btrfs-progs: scan: pass blkid_get_cache error code
Date: Tue, 28 May 2019 20:48:10 +0800 [thread overview]
Message-ID: <08dd7747-6af6-f820-419c-a0dc116b5688@oracle.com> (raw)
In-Reply-To: <20190515142911.GT3138@twin.jikos.cz>
On 15/5/19 10:29 PM, David Sterba wrote:
> On Fri, Mar 29, 2019 at 01:49:54PM +0800, Anand Jain wrote:
>> blkid_get_cache() returns error code which is -errno. So we can use them
>> directly.
>>
>> Signed-off-by: Anand Jain <anand.jain@oracle.com>
>> ---
>> Ref:
>> blkid_get_cache() code:
>> https://github.com/karelzak/util-linux/blob/master/libblkid/src/cache.c#L93
>> https://github.com/karelzak/util-linux/blob/master/libblkid/src/blkidP.h#L307
>
> This is internal header of blkid and incidentally the error numbers
> match errnos, but I don't think we should rely on that. Does blkid have
> a function that translates the code to string, similar to strerror?
>
Uh. No there isn't BLKID_ERR.. to string conversion.
next prev parent reply other threads:[~2019-05-28 12:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 5:49 [PATCH 1/2] btrfs-progs: scan: cleanup, return errno when we have one Anand Jain
2019-03-29 5:49 ` [PATCH 2/2] btrfs-progs: scan: pass blkid_get_cache error code Anand Jain
2019-05-15 14:29 ` David Sterba
2019-05-28 12:48 ` Anand Jain [this message]
2019-05-15 14:26 ` [PATCH 1/2] btrfs-progs: scan: cleanup, return errno when we have one David Sterba
2019-05-28 12:47 ` Anand Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=08dd7747-6af6-f820-419c-a0dc116b5688@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).