Re: [PATCH] btrfs: fix off-by-one end offset check in report_setget_bounds()

[Qu Wenruo <wqu@suse.com>]

在 2026/10/1 00:49, fdmanana@kernel.org 写道:
> From: Filipe Manana <fdmanana@suse.com>
> 
> The addressable range with an extent buffer goes from byte 0 to byte
> eb->len - 1, so if a byte address matches eb->len, it's already beyond
> the addressable range and we should log that it's bad start address
> and not end address.
> 
> Fixes: 234fdd2815ce ("btrfs: remove redundant check in up check_setget_bounds")
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/accessors.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/accessors.c b/fs/btrfs/accessors.c
> index 1248aa2535d3..d63ac6eb92de 100644
> --- a/fs/btrfs/accessors.c
> +++ b/fs/btrfs/accessors.c
> @@ -16,7 +16,7 @@ static void __cold report_setget_bounds(const struct extent_buffer *eb,
>   
>   	btrfs_warn(eb->fs_info,
>   		   "bad eb member %s: ptr 0x%lx start %llu member offset %lu size %d",
> -		   (member_offset > eb->len ? "start" : "end"),
> +		   (member_offset >= eb->len ? "start" : "end"),
>   		   (unsigned long)ptr, eb->start, member_offset, size);
>   }
>