From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2 3/6] btrfs: introduce the skeleton of delayed bbio endio function
Date: Sat, 16 May 2026 13:15:16 +0930 [thread overview]
Message-ID: <0b7da3ffcb84017feafcb02dc3a93fa49f4885a5.1778902677.git.wqu@suse.com> (raw)
In-Reply-To: <cover.1778902677.git.wqu@suse.com>
A delayed bbio will not be directly submitted, but queued into a
workqueue, to perform compression there.
The compression and uncompressed fallback are not implemented in this
patch.
Only the main endio function and helper to queue workload into a
workqueue is implemented.
The endio function is mostly the same as end_bbio_data_write(), except
for the extra memory allocation/freeing for the bbio->private.
Signed-off-by: Qu Wenruo <wqu@suse.com>
---
fs/btrfs/inode.c | 67 +++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 63 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 6c4fbd0d4845..43e4779a0f27 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -97,6 +97,12 @@ struct data_reloc_warn {
int mirror_num;
};
+struct delayed_bio_private {
+ struct work_struct work;
+ struct btrfs_bio *delayed_bbio;
+ atomic_t pending_ios;
+};
+
/*
* For the file_extent_tree, we want to hold the inode lock when we lookup and
* update the disk_i_size, but lockdep will complain because our io_tree we hold
@@ -7515,18 +7521,71 @@ struct extent_map *btrfs_create_delayed_em(struct btrfs_inode *inode,
return em;
}
-void btrfs_submit_delayed_write(struct btrfs_bio *bbio)
+static void run_delayed_bbio(struct work_struct *work)
{
- ASSERT(bbio->is_delayed);
+ struct delayed_bio_private *dbp = container_of(work, struct delayed_bio_private, work);
+ struct btrfs_bio *parent = dbp->delayed_bbio;
/*
- * Not yet implemented, and should not hit this path as we have no
- * caller to create delayed extent map.
+ * Increase the pending_ios so that parent bbio won't end
+ * until all child ones are submitted.
*/
+ atomic_inc(&dbp->pending_ios);
+ /* Compressed and uncompressed fallback is not yet implemented. */
ASSERT(0);
+ if (atomic_dec_and_test(&dbp->pending_ios))
+ btrfs_bio_end_io(parent, parent->status);
+}
+
+static void end_bbio_delayed(struct btrfs_bio *bbio)
+{
+ struct delayed_bio_private *dbp = bbio->private;
+ struct btrfs_inode *inode = bbio->inode;
+ struct btrfs_fs_info *fs_info = inode->root->fs_info;
+ struct folio_iter fi;
+ const u32 bio_size = bio_get_size(&bbio->bio);
+ const bool uptodate = bbio->status == BLK_STS_OK;
+
+ ASSERT(bbio->is_delayed);
+
+ bio_for_each_folio_all(fi, &bbio->bio) {
+ u64 start = folio_pos(fi.folio) + fi.offset;
+ u32 len = fi.length;
+
+ btrfs_folio_clear_writeback(fs_info, fi.folio, start, len);
+ }
+ btrfs_mark_ordered_io_finished(inode, bbio->file_offset, bio_size, uptodate);
+ kfree(dbp);
bio_put(&bbio->bio);
}
+void btrfs_submit_delayed_write(struct btrfs_bio *bbio)
+{
+ struct delayed_bio_private *dbp;
+
+ ASSERT(bbio->is_delayed);
+
+ bbio->end_io = end_bbio_delayed;
+ dbp = kzalloc(sizeof(struct delayed_bio_private), GFP_NOFS);
+ if (!dbp) {
+ btrfs_bio_end_io(bbio, errno_to_blk_status(-ENOMEM));
+ return;
+ }
+ atomic_set(&dbp->pending_ios, 0);
+ dbp->delayed_bbio = bbio;
+ bbio->private = dbp;
+ /*
+ * TODO: find a way to properly allow sequential extent allocation.
+ *
+ * The existing btrfs async workqueue will execute the sequential workload
+ * twice, the second one to free the structure.
+ * But our current submission path can only be called once, after that
+ * the bbio will be gone thus can not afford to use btrfs async workqueue.
+ */
+ INIT_WORK(&dbp->work, run_delayed_bbio);
+ schedule_work(&dbp->work);
+}
+
/*
* For release_folio() and invalidate_folio() we have a race window where
* folio_end_writeback() is called but the subpage spinlock is not yet released.
--
2.54.0
next prev parent reply other threads:[~2026-05-16 3:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 3:45 [PATCH v2 0/6] btrfs: delay compression to bbio submission time Qu Wenruo
2026-05-16 3:45 ` [PATCH v2 1/6] btrfs: add skeleton for delayed btrfs bio Qu Wenruo
2026-05-16 3:45 ` [PATCH v2 2/6] btrfs: add delayed ordered extent support Qu Wenruo
2026-05-16 3:45 ` Qu Wenruo [this message]
2026-05-16 3:45 ` [PATCH v2 4/6] btrfs: introduce compression for delayed bbio Qu Wenruo
2026-05-16 3:45 ` [PATCH v2 5/6] btrfs: implement uncompressed fallback " Qu Wenruo
2026-05-16 3:45 ` [PATCH v2 6/6] btrfs: enable experimental delayed compression support Qu Wenruo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b7da3ffcb84017feafcb02dc3a93fa49f4885a5.1778902677.git.wqu@suse.com \
--to=wqu@suse.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox