From: Anand Jain <anand.jain@oracle.com>
To: Qu Wenruo <wqu@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2] btrfs: Populate btrfs_super_block::log_root_transid
Date: Thu, 4 Oct 2018 16:07:51 +0800 [thread overview]
Message-ID: <0ce061ae-eeb3-a338-02e7-631b3818cb8a@oracle.com> (raw)
In-Reply-To: <20181004054950.11651-2-wqu@suse.com>
> we
> already expect log tree root generation always to be super block
> genration + 1.
This is close to what I was looking for by reading the cover-letter,
basically what is the impact/bug by not populating it? but can you
explain more, I wonder how was check working so long then?
> But it could be later used to detect log tree corruption early.
If there is no impact/bug its rather a good idea to change this when
the early log tree corruption detection part is ready. So that there
is absolute clarity.
The reason why I am grossly wary is - we have incomplete business
about how do we handle the write-hole, say raid1 to begin with.
Thanks, Anand
next prev parent reply other threads:[~2018-10-04 8:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 5:49 [PATCH 0/2] btrfs: btrfs_super_block::log_root_transid related enhancement Qu Wenruo
2018-10-04 5:49 ` [PATCH 1/2] btrfs: Populate btrfs_super_block::log_root_transid Qu Wenruo
2018-10-04 8:07 ` Anand Jain [this message]
2018-10-04 8:28 ` Qu Wenruo
2018-10-11 12:31 ` David Sterba
2018-10-11 12:45 ` Qu Wenruo
2018-10-11 13:11 ` Nikolay Borisov
2018-10-11 13:13 ` Qu Wenruo
2018-10-04 5:49 ` [PATCH 2/2] btrfs: Validate btrfs_super_block::log_root_transid Qu Wenruo
2018-10-04 6:57 ` Nikolay Borisov
2018-10-04 7:30 ` Qu Wenruo
2018-10-11 12:19 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ce061ae-eeb3-a338-02e7-631b3818cb8a@oracle.com \
--to=anand.jain@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).