Re: [PATCH 3/4] btrfs: preallocate anon_dev for subvolume and snapshot creation

Qu Wenruo
2020-07-03T12:39:34Z

[-- Attachment #1.1: Type: text/plain, Size: 1601 bytes --]

On 2020/7/3 下午8:29, David Sterba wrote:
> On Fri, Jul 03, 2020 at 01:19:14PM +0800, Qu Wenruo wrote:
>>>> In conclusion, your proposal is better and I'm going to merge it.
>>>>
>>>>> Although I would definitely remove the "__" prefix as we shouldn't add
>>>>> such prefix anymore.
>>>>
>>>> Yeah with the small naming fixups.
>>>
>>> It's in for-next-20200703. I've updated the changelogs to reflect what
>>> we found during debugging the issue, the __ function renamed to
>>> btrfs_get_root_ref and some function comments added. All patches
>>> reordered and tagged for stable though the preallocation is not within
>>> the size limit.
>>>
>>
>> Thanks for the merge and dropping the unneeded check patch.
>>
>> All the modification looks good to me.
>>
>> Just a small nitpick for commit a561defc34aa ("btrfs: don't allocate
>> anonymous block device for user invisible roots"), there is an
>> unnecessary new line after "[CAUSE]".
>
> Fixed, thanks for checking. I'm not entirely satisfied with the name of
> btrfs_get_root_ref, as it could be confused with the on-disk
> btrfs_root_ref.

My original plan is even simpler, just get_fs_root(), remove the btrfs_
prefix...

> The get-ref functions could use some cleanup as
> btrfs_get_fs_root is sometimes used for non-filesystem roots. Adding a
> generic get_any_root that would accept any tree and btrfs_get_fs_root
> would be only for subvolume roots or perhaps related trees like data
> reloc. But this is not essential for the anon bdev fixes so that's for
> later.

No problem.

Thanks,
Qu

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]