From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93D77C433F5 for ; Mon, 18 Apr 2022 07:00:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236431AbiDRHCx (ORCPT ); Mon, 18 Apr 2022 03:02:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232489AbiDRHCv (ORCPT ); Mon, 18 Apr 2022 03:02:51 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EEF9F25DC for ; Mon, 18 Apr 2022 00:00:11 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8F8C01F37D; Mon, 18 Apr 2022 07:00:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1650265210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rWlueotSBNM8IHlesGC1fnBLLUK2HCLvB5OyLehRoU0=; b=VdyFqFE92Y0VPzDecuTfq7PCS8pKip9DR941b3f48Ha7foqUM0DF7v1P1fHl1RkYvj+Yxc zFVDQXzxcy0bSedA/A4DZeel9euP73zJBB15dfj3wgG/RJOcY/5yn5Akd0nBlzIItnUDUv QQI9bB0cflynZ5I5jSnwiBctnmEdapg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1160D13A9B; Mon, 18 Apr 2022 07:00:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id /rldAHoMXWLLXgAAMHmgww (envelope-from ); Mon, 18 Apr 2022 07:00:09 +0000 Message-ID: <0d70749d-a10c-a426-7a56-c68e0afeb065@suse.com> Date: Mon, 18 Apr 2022 10:00:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 1/2] btrfs: export a helper for compression hard check Content-Language: en-US To: Chung-Chiang Cheng , dsterba@suse.com, fdmanana@kernel.org Cc: josef@toxicpanda.com, clm@fb.com, linux-btrfs@vger.kernel.org, shepjeng@gmail.com, kernel@cccheng.net References: <20220415080406.234967-1-cccheng@synology.com> From: Nikolay Borisov In-Reply-To: <20220415080406.234967-1-cccheng@synology.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 15.04.22 г. 11:04 ч., Chung-Chiang Cheng wrote: > inode_can_compress will be used outside of inode.c to check the > availability of setting compression flag by xattr. This patch moves > this function as an internal helper and renames it to > btrfs_inode_can_compress. > > Signed-off-by: Chung-Chiang Cheng The whole series LGTM: Reviewed-by: Nikolay Borisov Still, providin an fstest is highly desirable.