[PATCH] btrfs: pass 'verbose' parameter to btrfs_relocate_block_group

[PATCH] btrfs: pass 'verbose' parameter to btrfs_relocate_block_group

[Johannes Thumshirn]

Function `btrfs_relocate_chunk()` always passes verbose=true to
`btrfs_relocate_block_group()` instead of the `verbose` parameter passed
into it by it's callers.

While user initiated rebalancing should be logged in the Kernel's log
buffer. This causes excessive log spamming from automatic rebalancing,
e.g. on zoned filesystems running low on usable space.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 fs/btrfs/volumes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
index c0cf8f7c5a8e..95accc9361bd 100644
--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -3595,7 +3595,7 @@ int btrfs_relocate_chunk(struct btrfs_fs_info *fs_info, u64 chunk_offset, bool v
 
 	/* step one, relocate all the extents inside this chunk */
 	btrfs_scrub_pause(fs_info);
-	ret = btrfs_relocate_block_group(fs_info, chunk_offset, true);
+	ret = btrfs_relocate_block_group(fs_info, chunk_offset, verbose);
 	btrfs_scrub_continue(fs_info);
 	if (ret) {
 		/*
-- 
2.53.0

Re: [PATCH] btrfs: pass 'verbose' parameter to btrfs_relocate_block_group

[Damien Le Moal]

On 2/27/26 22:12, Johannes Thumshirn wrote:
> Function `btrfs_relocate_chunk()` always passes verbose=true to
> `btrfs_relocate_block_group()` instead of the `verbose` parameter passed
> into it by it's callers.
> 
> While user initiated rebalancing should be logged in the Kernel's log
> buffer. This causes excessive log spamming from automatic rebalancing,
> e.g. on zoned filesystems running low on usable space.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Reviewed-by: Damien Le Moal <dlemoal@kernel.org>


-- 
Damien Le Moal
Western Digital Research

Re: [PATCH] btrfs: pass 'verbose' parameter to btrfs_relocate_block_group

[Qu Wenruo]

在 2026/2/27 23:42, Johannes Thumshirn 写道:
> Function `btrfs_relocate_chunk()` always passes verbose=true to
> `btrfs_relocate_block_group()` instead of the `verbose` parameter passed
> into it by it's callers.
> 
> While user initiated rebalancing should be logged in the Kernel's log
> buffer. This causes excessive log spamming from automatic rebalancing,
> e.g. on zoned filesystems running low on usable space.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Reviewed-by: Qu Wenruo <wqu@suse.com>

Thanks,
Qu

> ---
>   fs/btrfs/volumes.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index c0cf8f7c5a8e..95accc9361bd 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -3595,7 +3595,7 @@ int btrfs_relocate_chunk(struct btrfs_fs_info *fs_info, u64 chunk_offset, bool v
>   
>   	/* step one, relocate all the extents inside this chunk */
>   	btrfs_scrub_pause(fs_info);
> -	ret = btrfs_relocate_block_group(fs_info, chunk_offset, true);
> +	ret = btrfs_relocate_block_group(fs_info, chunk_offset, verbose);
>   	btrfs_scrub_continue(fs_info);
>   	if (ret) {
>   		/*

Re: [PATCH] btrfs: pass 'verbose' parameter to btrfs_relocate_block_group

[Filipe Manana]

On Fri, Feb 27, 2026 at 1:14 PM Johannes Thumshirn
<johannes.thumshirn@wdc.com> wrote:
>
> Function `btrfs_relocate_chunk()` always passes verbose=true to
> `btrfs_relocate_block_group()` instead of the `verbose` parameter passed
> into it by it's callers.
>
> While user initiated rebalancing should be logged in the Kernel's log
> buffer. This causes excessive log spamming from automatic rebalancing,
> e.g. on zoned filesystems running low on usable space.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

Reviewed-by: Filipe Manana <fdmanana@suse.com>

Looks good, thanks.

> ---
>  fs/btrfs/volumes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index c0cf8f7c5a8e..95accc9361bd 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -3595,7 +3595,7 @@ int btrfs_relocate_chunk(struct btrfs_fs_info *fs_info, u64 chunk_offset, bool v
>
>         /* step one, relocate all the extents inside this chunk */
>         btrfs_scrub_pause(fs_info);
> -       ret = btrfs_relocate_block_group(fs_info, chunk_offset, true);
> +       ret = btrfs_relocate_block_group(fs_info, chunk_offset, verbose);
>         btrfs_scrub_continue(fs_info);
>         if (ret) {
>                 /*
> --
> 2.53.0
>
>