From: Burenchev Evgenii <EBurenchev@orionsoft.ru>
To: "dsterba@suse.cz" <dsterba@suse.cz>
Cc: "clm@fb.com" <clm@fb.com>, "dsterba@suse.com" <dsterba@suse.com>,
"linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"lvc-project@linuxtesting.org" <lvc-project@linuxtesting.org>,
"mssola@mssola.com" <mssola@mssola.com>,
"fdmanana@kernel.org" <fdmanana@kernel.org>
Subject: [PATCH v2 1/2] btrfs: remove dead assignment to dirid in btrfs_search_path_in_tree()
Date: Wed, 25 Feb 2026 12:41:02 +0000 [thread overview]
Message-ID: <10496334e2624a818aa786a697833f67@orionsoft.ru> (raw)
Related discussion: https://lore.kernel.org/linux-btrfs/20260224172835.GB26902@twin.jikos.cz
After the introduction of btrfs_search_backwards(),
the directory traversal state in btrfs_search_path_in_tree() is fully
maintained via struct btrfs_key.
The assignment:
dirid = key.objectid;
no longer affects control flow and is dead code.
Remove the unused assignment to avoid confusion and silence static analysis
warnings.
No functional change.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Changes since v1:
- split from original patch
Signed-off-by: Evgenii Burenchev <eburenchev@orionsoft.ru>
---
fs/btrfs/ioctl.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c
index ae2173235c4d..3a45ee1a7026 100644
--- a/fs/btrfs/ioctl.c
+++ b/fs/btrfs/ioctl.c
@@ -1707,7 +1707,6 @@ static noinline int btrfs_search_path_in_tree(struct btrfs_fs_info *info,
btrfs_release_path(path);
key.objectid = key.offset;
key.offset = (u64)-1;
- dirid = key.objectid;
}
memmove(name, ptr, total_len);
name[total_len] = '\0';
--
2.43.0
reply other threads:[~2026-02-25 12:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10496334e2624a818aa786a697833f67@orionsoft.ru \
--to=eburenchev@orionsoft.ru \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=dsterba@suse.cz \
--cc=fdmanana@kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
--cc=mssola@mssola.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox