public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <quwenruo.btrfs@gmx.com>
To: David Sterba <dsterba@suse.com>, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 00/12] Cleanups of blk_status_t use
Date: Thu, 24 Apr 2025 15:04:21 +0930	[thread overview]
Message-ID: <1142ff0f-4296-4877-b8b6-1be2f78ff9ad@gmx.com> (raw)
In-Reply-To: <cover.1745422901.git.dsterba@suse.com>



在 2025/4/24 01:27, David Sterba 写道:
> Use the blk_status_t only for interaction with block layer API and
> remove it from our functions. Do some naming unifications and minor
> cleanups.

Reviewed-by: Qu Wenruo <wqu@suse.com>

Although I'm wondering if it's even possible to require a forced 
compiler warning when using blk_status_t as other types and vice verse?

Thanks,
Qu

> 
> David Sterba (12):
>    btrfs: drop redundant local variable in raid_wait_write_end_io()
>    btrfs: change return type of btrfs_lookup_bio_sums() to int
>    btrfs: change return type of btrfs_csum_one_bio() to int
>    btrfs: change return type of btree_csum_one_bio() to int
>    btrfs: change return type of btrfs_bio_csum() to int
>    btrfs: rename ret to status in btrfs_submit_chunk()
>    btrfs: rename error to ret in btrfs_submit_chunk()
>    btrfs: simplify reading bio status in end_compressed_writeback()
>    btrfs: rename ret to status in btrfs_submit_compressed_read()
>    btrfs: rename ret2 to ret in btrfs_submit_compressed_read()
>    btrfs: change return type of btrfs_alloc_dummy_sum() to int
>    btrfs: raid56: rename parameter err to status in endio helpers
> 
>   fs/btrfs/bio.c         | 33 ++++++++++++++++++---------------
>   fs/btrfs/compression.c | 22 +++++++++++-----------
>   fs/btrfs/disk-io.c     | 16 ++++++++--------
>   fs/btrfs/disk-io.h     |  2 +-
>   fs/btrfs/file-item.c   | 20 ++++++++++----------
>   fs/btrfs/file-item.h   |  6 +++---
>   fs/btrfs/raid56.c      | 13 ++++++-------
>   7 files changed, 57 insertions(+), 55 deletions(-)
> 

  parent reply	other threads:[~2025-04-24  5:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-23 15:57 [PATCH 00/12] Cleanups of blk_status_t use David Sterba
2025-04-23 15:57 ` [PATCH 01/12] btrfs: drop redundant local variable in raid_wait_write_end_io() David Sterba
2025-04-23 15:57 ` [PATCH 02/12] btrfs: change return type of btrfs_lookup_bio_sums() to int David Sterba
2025-04-23 15:57 ` [PATCH 03/12] btrfs: change return type of btrfs_csum_one_bio() " David Sterba
2025-04-23 15:57 ` [PATCH 04/12] btrfs: change return type of btree_csum_one_bio() " David Sterba
2025-04-23 15:57 ` [PATCH 05/12] btrfs: change return type of btrfs_bio_csum() " David Sterba
2025-04-23 15:57 ` [PATCH 06/12] btrfs: rename ret to status in btrfs_submit_chunk() David Sterba
2025-04-23 15:57 ` [PATCH 07/12] btrfs: rename error to ret " David Sterba
2025-04-23 15:57 ` [PATCH 08/12] btrfs: simplify reading bio status in end_compressed_writeback() David Sterba
2025-04-23 15:57 ` [PATCH 09/12] btrfs: rename ret to status in btrfs_submit_compressed_read() David Sterba
2025-04-23 15:57 ` [PATCH 10/12] btrfs: rename ret2 to ret " David Sterba
2025-04-23 15:57 ` [PATCH 11/12] btrfs: change return type of btrfs_alloc_dummy_sum() to int David Sterba
2025-04-23 15:57 ` [PATCH 12/12] btrfs: raid56: rename parameter err to status in endio helpers David Sterba
2025-04-24  5:34 ` Qu Wenruo [this message]
2025-04-24  6:09   ` [PATCH 00/12] Cleanups of blk_status_t use David Sterba
2025-04-25 13:38     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1142ff0f-4296-4877-b8b6-1be2f78ff9ad@gmx.com \
    --to=quwenruo.btrfs@gmx.com \
    --cc=dsterba@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox