public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Josef Bacik <jbacik@redhat.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [RFC][PATCH] btrfs orphan code
Date: Wed, 25 Jun 2008 16:24:11 -0400	[thread overview]
Message-ID: <1214425451.10187.694.camel@think.oraclecorp.com> (raw)
In-Reply-To: <20080624180450.GA9813@unused.rdu.redhat.com>

On Tue, 2008-06-24 at 14:04 -0400, Josef Bacik wrote:
> Hello,
> 
> I want to throw this out here now that I've got most of the heavy lifting done
> for this code to make sure what I'm doing is ok for now.  I've added an
> ORPHAN_DIR item key to have a hidden dir per root.  Right now it just does it
> for whatever the default root is on mount, but I'm going to fix that to do the
> orphan dir check/creation on lookup of a subvolume root.  I also changed
> btrfs_insert_dir_item to take an index flag to indicate whether or not we want
> to add a DIR_INDEX item along with the dir item.  Let me know if there are any
> glaring design problems with what I've done.  Thanks much,
> 

Ok, I've poked my head out of the locking code now, this is a pretty
good start.  But, the plan you mentioned on irc to use a special item
type instead of a directory is a better way to go.

After that, we'll have to hammer on it a bit to flush out any races
between relinking a recently unlinked file and the orphan code.

Thanks a lot for tackling this.

-chris



      reply	other threads:[~2008-06-25 20:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-24 18:04 [RFC][PATCH] btrfs orphan code Josef Bacik
2008-06-25 20:24 ` Chris Mason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214425451.10187.694.camel@think.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=jbacik@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox