From: Chris Mason <chris.mason@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
Balaji Rao <balajirrao@gmail.com>,
linux-btrfs@vger.kernel.org
Subject: Re: Problem during implementing NFS support
Date: Mon, 21 Jul 2008 08:58:23 -0400 [thread overview]
Message-ID: <1216645103.6932.92.camel@think.oraclecorp.com> (raw)
In-Reply-To: <20080721081037.GA24230@infradead.org>
On Mon, 2008-07-21 at 04:10 -0400, Christoph Hellwig wrote:
> On Sun, Jul 20, 2008 at 09:43:50AM -0700, David Woodhouse wrote:
> > The way GFS1 (and also XFS iirc) handles it is to build up a complete
> > list of responses to readdir() in a buffer, drop the lock, and then
> > iterate over that buffer calling filldir(). I don't much like that
> > version either.
>
> Yes. My prefered mid-term solution would to simply lift that code from
> XFS (where it's nicely isolated and all code is prefixed with hack_) to
> nfsd so that local users don't aren't penalized for this.
>
Reiserfs also uses the local buffer and lock dropping trick, and that's
what I would do for now in btrfs.
But, the extent allocation tree also needs recursive locking, so I'm
going to take a stab at that as soon as I get the pending patch list
merged.
-chris
prev parent reply other threads:[~2008-07-21 12:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 19:11 Problem during implementing NFS support Balaji Rao
2008-07-20 16:43 ` David Woodhouse
2008-07-20 19:36 ` Balaji Rao
2008-07-20 20:08 ` David Woodhouse
2008-07-21 8:10 ` Christoph Hellwig
2008-07-21 12:58 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216645103.6932.92.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=balajirrao@gmail.com \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox