From: Chris Mason <chris.mason@oracle.com>
To: Ahmed Kamal <email.ahmedkamal@googlemail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: Fix: btrfsctl arguments handling
Date: Tue, 29 Jul 2008 15:17:24 +0000 [thread overview]
Message-ID: <1217344644.7572.128.camel@think.oraclecorp.com> (raw)
In-Reply-To: <3da3b5b40807271202r43b887e9gfadad07ab2c3233e@mail.gmail.com>
On Sun, 2008-07-27 at 22:02 +0300, Ahmed Kamal wrote:
> Is this not a valid patch/fix ? Who do I have to bug to get this merged :)
>
It looks fine, I'll queue it up.
Thanks,
Chris
> On Fri, Jul 18, 2008 at 7:44 PM, Ahmed Kamal
> <email.ahmedkamal@googlemail.com> wrote:
> >
> > That's probably a more proper patch
> >
> > # HG changeset patch
> > # Signed-Off-By: Ahmed Kamal <email.ahmedkamal@googlemail.com>
> > # Date 1216410189 -10800
> > # Node ID f35e2b3b25a97d42452ec90b6c524721d9c9941f
> > # Parent 1aa4b32e3efd452531cb0b883edfcc3761487fca
> > Fixing btrfsctl argument handling
> >
> > diff -r 1aa4b32e3efd -r f35e2b3b25a9 btrfsctl.c
> > --- a/btrfsctl.c Tue Jun 10 10:09:18 2008 -0400
> > +++ b/btrfsctl.c Fri Jul 18 22:43:09 2008 +0300
> > @@ -73,7 +73,7 @@
> > btrfs_scan_one_dir("/dev", 1);
> > exit(0);
> > }
> > - for (i = 1; i < ac - 1; i++) {
> > + for (i = 1; i <= ac - 1; i++) {
> > if (strcmp(av[i], "-s") == 0) {
> > if (i + 1 >= ac - 1) {
> > fprintf(stderr, "-s requires an arg");
> >
> >
> > On Fri, Jul 18, 2008 at 7:37 PM, Ahmed Kamal
> > <email.ahmedkamal@googlemail.com> wrote:
> > > Hi,
> > >
> > > btrfsctl -A
> > > in the current -unstable branch, does not result in the error message
> > > designated for it, namely "-A requires an arg\n". Turns out the whole
> > > loop was being skipped!
> > > Please find a patch attached that fixed it for me.
> > >
> > > diff -r 1aa4b32e3efd btrfsctl.c
> > > --- a/btrfsctl.c Tue Jun 10 10:09:18 2008 -0400
> > > +++ b/btrfsctl.c Fri Jul 18 22:34:46 2008 +0300
> > > @@ -73,7 +73,7 @@
> > > btrfs_scan_one_dir("/dev", 1);
> > > exit(0);
> > > }
> > > - for (i = 1; i < ac - 1; i++) {
> > > + for (i = 1; i <= ac - 1; i++) {
> > > if (strcmp(av[i], "-s") == 0) {
> > > if (i + 1 >= ac - 1) {
> > > fprintf(stderr, "-s requires an arg");
> > >
> > >
> > > PS: Is this the correct way to submit patches ?
> > >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-07-29 15:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 16:37 Fix: btrfsctl arguments handling Ahmed Kamal
2008-07-18 16:44 ` Ahmed Kamal
2008-07-27 19:02 ` Ahmed Kamal
2008-07-29 15:17 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217344644.7572.128.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=email.ahmedkamal@googlemail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox