From: Chris Mason <chris.mason@oracle.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: block discard.
Date: Fri, 08 Aug 2008 10:13:09 -0400 [thread overview]
Message-ID: <1218204789.15342.237.camel@think.oraclecorp.com> (raw)
In-Reply-To: <1218204617.12232.171.camel@pmac.infradead.org>
On Fri, 2008-08-08 at 15:10 +0100, David Woodhouse wrote:
> On Fri, 2008-08-08 at 15:05 +0100, David Woodhouse wrote:
> > On Fri, 2008-08-08 at 09:56 -0400, Chris Mason wrote:
> > > So you mkfs ; dd large file ; rm large file ; look for discards?
> > >
> > > Try rm large file ; sync ; sync; look for discards
> >
> > Yeah, I did that. The actual data extent isn't getting removed.
>
> Oh, you really did mean _two_ syncs. And then yes, I see why it isn't
> working; mea culpa.
>
The first sync commits the transaction and writes out the data. The
second sync does the same thing, but this time it finds the old snapshot
pending deletion and deletes it.
-chris
prev parent reply other threads:[~2008-08-08 14:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 13:43 block discard David Woodhouse
2008-08-08 13:56 ` Chris Mason
2008-08-08 14:05 ` David Woodhouse
2008-08-08 14:10 ` David Woodhouse
2008-08-08 14:13 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218204789.15342.237.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=dwmw2@infradead.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox