From: David Woodhouse <dwmw2@infradead.org>
To: Balaji Rao <balajirrao@gmail.com>
Cc: linux-btrfs@vger.kernel.org, Chris Mason <chris.mason@oracle.com>
Subject: Re: [PATCH] NFS support for btrfs - v2
Date: Sun, 17 Aug 2008 14:30:17 +0100 [thread overview]
Message-ID: <1218979817.3184.296.camel@pmac.infradead.org> (raw)
In-Reply-To: <200808171854.14275.balajirrao@gmail.com>
On Sun, 2008-08-17 at 18:54 +0530, Balaji Rao wrote:
>
>
> OK. I had copied over this code snippet from
> inode.c:btrfs_inode_by_name,
> which has the condition 'if (slot >= nritems)' removed now by this.
>
> changeset: 631:87490dc3bb59
> user: "Yan Zheng" <yanzheng@21cn.com>
> date: Thu Jul 24 12:19:32 2008 -0400
> summary: Fix .. lookup corner case
>
> I think we should refactor btrfs_inode_by_name into something we can
> use ?
I'm not entirely sure why btrfs_inode_by_name() handles "." and ".." at
all. We haven't needed that since the 2.2 kernel, have we?
I think we should just remove that code completely -- and remove the
similar code from btrfs_real_readdir() while we're at it -- just use
parent_ino(filp->f_path.dentry) instead. In _that_ case, we know the
dcache is connected.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2008-08-17 13:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 20:31 [PATCH] NFS support for btrfs - v2 Balaji Rao
2008-08-17 11:53 ` David Woodhouse
2008-08-17 12:51 ` Balaji Rao
2008-08-17 12:56 ` David Woodhouse
2008-08-17 13:24 ` Balaji Rao
2008-08-17 13:30 ` David Woodhouse [this message]
2008-08-17 14:17 ` David Woodhouse
2008-08-17 16:10 ` [PATCH] rewrite btrfs_readdir() David Woodhouse
2008-08-18 18:46 ` Chris Mason
2008-08-18 19:08 ` David Woodhouse
2008-08-18 19:24 ` Chris Mason
2008-08-18 19:32 ` David Woodhouse
2008-08-17 13:40 ` [PATCH] NFS support for btrfs - v2 David Woodhouse
2008-08-18 19:23 ` Chris Mason
2008-08-18 19:33 ` David Woodhouse
2008-08-18 19:47 ` Chris Mason
2008-08-18 20:20 ` David Woodhouse
2008-08-18 20:32 ` Chris Mason
2008-08-18 21:52 ` David Woodhouse
2008-08-19 11:54 ` Chris Mason
2008-08-19 14:49 ` David Woodhouse
2008-08-19 21:34 ` David Woodhouse
2008-08-19 0:16 ` Christoph Hellwig
2008-08-19 0:21 ` David Woodhouse
2008-08-18 11:51 ` David Woodhouse
2008-08-18 12:10 ` David Woodhouse
2008-08-18 19:15 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218979817.3184.296.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=balajirrao@gmail.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox