From: Chris Mason <chris.mason@oracle.com>
To: Liu Hui <onlyflyer@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATH]Some fix for batching extent insert.
Date: Tue, 18 Nov 2008 07:30:17 -0500 [thread overview]
Message-ID: <1227011417.15917.3.camel@think.oraclecorp.com> (raw)
In-Reply-To: <1227010670.15917.2.camel@think.oraclecorp.com>
On Tue, 2008-11-18 at 07:17 -0500, Chris Mason wrote:
> On Mon, 2008-11-17 at 23:48 +0800, Liu Hui wrote:
> > Hi,
> > When I review the code about batching extent insert, I found some code
> > could result in problems in some corner cases.
> > 1)In finish_current_insert(), when it finds nothing to insert and it
> > has skipped some locked extents, it should try again to see if the
> > locked extent is unlocked. So, it will re-search the extent_ins
> > extent_io_tree by reseting 'search' to 0. There is one place forget to
> > reset the 'search' pointer to 0 which will lead BTRFS not to finish
> > *all* current insert.
> >
>
> Thanks for spending time on this, but I'm afraid this patch leads to
> infinite looping in finish_current_insert under stress testing.
Ah, I see there is a check later in finish_current_insert to make sure
we don't miss anything. I'm retesting with just that hunk removed.
-chris
next prev parent reply other threads:[~2008-11-18 12:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-17 15:48 [PATH]Some fix for batching extent insert Liu Hui
2008-11-18 12:17 ` Chris Mason
2008-11-18 12:30 ` Chris Mason [this message]
2008-11-18 14:35 ` yanhai zhu
2008-11-18 14:48 ` Chris Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1227011417.15917.3.camel@think.oraclecorp.com \
--to=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=onlyflyer@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox