public inbox for linux-btrfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Sage Weil <sage@newdream.net>
Cc: Yan Zheng <yanzheng@21cn.com>, linux-btrfs@vger.kernel.org
Subject: Re: inode data not getting included in commits?
Date: Fri, 19 Dec 2008 09:12:55 -0500	[thread overview]
Message-ID: <1229695975.6270.12.camel@think.oraclecorp.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0812182104580.25096@cobra.newdream.net>

On Thu, 2008-12-18 at 21:21 -0800, Sage Weil wrote:
> On Fri, 19 Dec 2008, Yan Zheng wrote:
> > > I noticed some data and metadata getting out of sync on disk, despite
> > > wrapping my writes with btrfs transactions.  After digging into it a bit,
> > > it appears to be a larger problem with inode size/data getting written
> > > during a regular commit.
> > > [...]
> > 
> > This is the desired behaviour of data=ordered. Btrfs transaction commit
> > don't flush data, and metadata wont get updated until data IO complete.
> > 
> > http://article.gmane.org/gmane.comp.file-systems.btrfs/869/match=new+data+ordered+code
> 
> Ah, right, so it is.
> 
> I think what I'm looking for then is a mount mode to get the old behavior, 
> such that each commit flushes previously written data.  Probably a call to 
> btrfs_wait_ordered_extents() in btrfs_commit_transaction(), or something 
> along those lines...

Could you describe the end goal a bit?  I'm happy to make modes where
it'll do what you need.

-chris



  reply	other threads:[~2008-12-19 14:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-19  0:22 inode data not getting included in commits? Sage Weil
2008-12-19  1:26 ` Yan Zheng
2008-12-19  5:21   ` Sage Weil
2008-12-19 14:12     ` Chris Mason [this message]
2008-12-19 18:48       ` Sage Weil
2008-12-19 19:07         ` Chris Mason
2008-12-19 20:08           ` Sage Weil
2008-12-20  0:11             ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1229695975.6270.12.camel@think.oraclecorp.com \
    --to=chris.mason@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=sage@newdream.net \
    --cc=yanzheng@21cn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox