From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Peter W. Morreale" Subject: Re: [PATCH -v5][RFC]: mutex: implement adaptive spinning Date: Wed, 07 Jan 2009 23:14:24 +0000 Message-ID: <1231370064.3470.516.camel@hermosa.site> References: <1231283778.11687.136.camel@twins> <1231329783.11687.287.camel@twins> <1231347442.11687.344.camel@twins> <20090107210923.GV2002@parisc-linux.org> <20090107213924.GP496@one.firstfloor.org> <49652C7C.3000909@novell.com> <20090107223317.GB27629@elte.hu> <1231368665.3470.513.camel@hermosa.site> Mime-Version: 1.0 Content-Type: text/plain Cc: Gregory Haskins , Andi Kleen , Matthew Wilcox , Linus Torvalds , Steven Rostedt , Peter Zijlstra , paulmck@linux.vnet.ibm.com, Chris Mason , Andrew Morton , Linux Kernel Mailing List , linux-fsdevel , linux-btrfs , Thomas Gleixner , Nick Piggin , Sven Dietrich To: Ingo Molnar Return-path: In-Reply-To: <1231368665.3470.513.camel@hermosa.site> List-ID: On Wed, 2009-01-07 at 15:51 -0700, Peter W. Morreale wrote: > On Wed, 2009-01-07 at 23:33 +0100, Ingo Molnar wrote: > > * Gregory Haskins wrote: > > > > > Can I ask a simple question in light of all this discussion? > > > > > > "Is get_task_struct() really that bad?" > > > > it dirties a cacheline and it also involves atomics. > > > > Also, it's a small design cleanliness issue to me: get_task_struct() > > impacts the lifetime of an object - and if a locking primitive has > > side-effects on object lifetimes that's never nice. > > > > True, but it's for one iteration * NR_CPUS, max. > > Best, > -PWM Never mind. Bogus argument. That's why we have you Big Guns out there... - To keep us rif-raf in line... :-) Best, -PWM