From: David Woodhouse <dwmw2@infradead.org>
To: Chris Mason <chris.mason@oracle.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: remove crc32c.h and use libcrc32c directly.
Date: Mon, 20 Apr 2009 00:19:31 +0100 [thread overview]
Message-ID: <1240183171.3589.421.camel@macbook.infradead.org> (raw)
In-Reply-To: <1240182709.8932.2.camel@think.oraclecorp.com>
On Sun, 2009-04-19 at 19:11 -0400, Chris Mason wrote:
> How does this enable the HW crc32c? Unless I'm missing something you're
> doing crc32c instead of btrfs_crc32c, but btrfs_crc32c was #defined to
> crc32c?
It doesn't. You're _already_ using the hardware crc32c.
Since commit 69c35efc, all users of crc32c() in libcrc32c are actually
using the cryptoapi and thus any accelerated hardware implementations
that are available:
libcrc32c: Move implementation to crypto crc32c
This patch swaps the role of libcrc32c and crc32c. Previously
the implementation was in libcrc32c and crc32c was a wrapper.
Now the code is in crc32c and libcrc32c just calls the crypto
layer.
The reason for the change is to tap into the algorithm selection
capability of the crypto API so that optimised implementations
such as the one utilising Intel's CRC32C instruction can be
used where available.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2009-04-19 23:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 12:02 [PATCH] btrfs: remove crc32c.h and use libcrc32c directly David Woodhouse
2009-04-19 23:11 ` Chris Mason
2009-04-19 23:19 ` David Woodhouse [this message]
2009-04-19 23:30 ` Chris Mason
2009-04-19 23:41 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1240183171.3589.421.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox