From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Woodhouse Subject: Re: [PATCH] btrfs: remove crc32c.h and use libcrc32c directly. Date: Mon, 20 Apr 2009 00:41:05 +0100 Message-ID: <1240184465.11524.0.camel@macbook.infradead.org> References: <1240142561.3589.143.camel@macbook.infradead.org> <1240182709.8932.2.camel@think.oraclecorp.com> <1240183171.3589.421.camel@macbook.infradead.org> <1240183836.10853.1.camel@think.oraclecorp.com> Mime-Version: 1.0 Content-Type: text/plain Cc: linux-btrfs@vger.kernel.org To: Chris Mason Return-path: In-Reply-To: <1240183836.10853.1.camel@think.oraclecorp.com> List-ID: On Sun, 2009-04-19 at 19:30 -0400, Chris Mason wrote: > On Mon, 2009-04-20 at 00:19 +0100, David Woodhouse wrote: > > On Sun, 2009-04-19 at 19:11 -0400, Chris Mason wrote: > > > How does this enable the HW crc32c? Unless I'm missing something you're > > > doing crc32c instead of btrfs_crc32c, but btrfs_crc32c was #defined to > > > crc32c? > > > > It doesn't. You're _already_ using the hardware crc32c. > > > > Ok, that makes more sense ;) I'll fixup the changelog when I merge the > patch. The changelog already said "libcrc32c now does that for us through the crypto API -- so we're already using the Intel crc32c acceleration where appropriate, without having to do anything special." -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation