Re: [PATCH v8 12/13] fstests: add _change_metadata_uuid helper

[Anand Suveer Jain <asj@kernel.org>]

On 2/9/26 04:53, Zorro Lang wrote:
> On Sat, Jul 25, 2026 at 03:39:09PM +0800, Anand Jain wrote:
>> _change_metadata_uuid changes the UUID of the golden filesystem before it
>> is cloned.
>>
>> Signed-off-by: Anand Jain <asj@kernel.org>
>> ---
>>  common/rc | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/common/rc b/common/rc
>> index f73251365a60..45cf9360ba73 100644
>> --- a/common/rc
>> +++ b/common/rc
>> @@ -1533,6 +1533,29 @@ _scratch_resvblks()
>>  	esac
>>  }
>>  
>> +# Change the metadata UUID of the given device to a newly generated one.
>> +# Args:
>> +#   $1: Block device path to modify.
>> +_change_metadata_uuid()
>> +{
>> +	local temp_mnt=$TEST_DIR/${seq}_mnt
>> +	local dev=$1
>> +


>> +	case $FSTYP in
>> +	xfs)
>> +		_require_command "$XFS_ADMIN_PROG" "xfs_admin"
>> +		$XFS_ADMIN_PROG -U generate $dev >> $seqres.full
>> +		;;
>> +	btrfs)
>> +		_require_command "$BTRFS_TUNE_PROG" "btrfstune"
> 
> How about split this function to _require_metadata_uuid_tool and
> _chanage_metadata_uuid ?

Splitting out _require_metadata_uuid_tool() is more modular, but I'm not
sure it's needed until we have multiple callers. With only a single
caller, an extra helper feels unnecessary. Inlining it makes the flow
easier to read and execute. Similar to how we handle this in the kernel.

Thanks, Anand


> 
>> +		$BTRFS_TUNE_PROG -m $dev
>> +		;;
>> +	*)
>> +		_notrun "Require filesystem with metadata_uuid feature"
>> +		;;
>> +	esac
>> +}
>> +
>>  # Create a small loop image, run an optional tuning function ($2) on it,
>>  # clone it, and attach both to loop devices, returned in ($1).
>>  # Args:
>> -- 
>> 2.43.0
>>