From: Chandan Rajendra <chandan@linux.vnet.ibm.com>
To: Qu Wenruo <quwenruo@cn.fujitsu.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH 1/2] btrfs: qgroup: Introduce extent changeset for qgroup reserve functions
Date: Tue, 13 Dec 2016 18:24:34 +0530 [thread overview]
Message-ID: <12571184.mBYZ8QYGcb@localhost.localdomain> (raw)
In-Reply-To: <20161202020307.6025-1-quwenruo@cn.fujitsu.com>
On Friday, December 02, 2016 10:03:06 AM Qu Wenruo wrote:
> Introduce a new parameter, struct extent_changeset for
> btrfs_qgroup_reserved_data() and its callers.
>
> Such extent_changeset was used in btrfs_qgroup_reserve_data() to record
> which range it reserved in current reserve, so it can free it at error
> path.
>
> The reason we need to export it to callers is, at buffered write error
> path, without knowing what exactly which range we reserved in current
> allocation, we can free space which is not reserved by us.
>
> This will lead to qgroup reserved space underflow.
The changes look good to me.
Reviewed-by: Chandan Rajendra <chandan@linux.vnet.ibm.com>
--
chandan
prev parent reply other threads:[~2016-12-13 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 2:03 [PATCH 1/2] btrfs: qgroup: Introduce extent changeset for qgroup reserve functions Qu Wenruo
2016-12-02 2:03 ` [PATCH 2/2] btrfs: qgroup: Fix qgroup reserved space underflow by only freeing reserved ranges Qu Wenruo
2016-12-13 12:56 ` Chandan Rajendra
2016-12-08 14:29 ` [PATCH 1/2] btrfs: qgroup: Introduce extent changeset for qgroup reserve functions Chandan Rajendra
2016-12-09 0:39 ` Qu Wenruo
2016-12-13 12:54 ` Chandan Rajendra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12571184.mBYZ8QYGcb@localhost.localdomain \
--to=chandan@linux.vnet.ibm.com \
--cc=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=quwenruo@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).