Linux Btrfs filesystem development
 help / color / mirror / Atom feed
From: Harshavardhana <harsha@gluster.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] fs/btrfs: Return EPERM for rmdir on subvolumes and snapshots
Date: Thu,  8 Apr 2010 13:35:31 -0700	[thread overview]
Message-ID: <1270758931-5291-1-git-send-email-harsha@gluster.com> (raw)

rmdir on subvolumes and snapshots should return "EPERM"
rather than ENOTEMPTY. Just to be more descriptive. 

Signed-off-by: Harshavardhana <harsha@gluster.com>
---
 fs/btrfs/inode.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index a85b90c..c0fbe03 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -2593,7 +2593,7 @@ static int btrfs_rmdir(struct inode *dir, struct dentry *dentry)
 
 	if (inode->i_size > BTRFS_EMPTY_DIR_SIZE ||
 	    inode->i_ino == BTRFS_FIRST_FREE_OBJECTID)
-		return -ENOTEMPTY;
+		return -EPERM;
 
 	ret = btrfs_reserve_metadata_space(root, 5);
 	if (ret)
-- 
1.6.6.1


             reply	other threads:[~2010-04-08 20:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-08 20:35 Harshavardhana [this message]
2010-04-08 22:07 ` [PATCH] fs/btrfs: Return EPERM for rmdir on subvolumes and snapshots David Brown
2010-04-08 22:35   ` Harshavardhana

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270758931-5291-1-git-send-email-harsha@gluster.com \
    --to=harsha@gluster.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox