From: David Woodhouse <dwmw2@infradead.org>
To: Josef Bacik <josef@redhat.com>
Cc: Chris Mason <chris.mason@oracle.com>, linux-btrfs@vger.kernel.org
Subject: Re: Updating RAID[56] support
Date: Fri, 30 Apr 2010 21:00:13 +0100 [thread overview]
Message-ID: <1272657613.31892.119.camel@macbook.infradead.org> (raw)
In-Reply-To: <20100430183904.GC2223@localhost.localdomain>
On Fri, 2010-04-30 at 14:39 -0400, Josef Bacik wrote:
> > It seems to work, and recovery is successful when I mount the file
> > system with -oro,degraded. But in read-write mode it'll oops (even
> > without the below patch) because it's trying to _write_ to the degraded
> > RAID6. Last time I was testing this, it wouldn't continue to write to
> > that block group; it would allocate a new one which didn't include the
> > missing disk. What changed?
> >
>
> Maybe that block group isn't getting marked read only? I'd need to see the oops
> to know what was going on. Thanks,
Yes, it's not getting marked read-only.
All the asynchronicity means that there isn't a clear backtrace. I put
extra checks in different places a few times, and the closest I got was
WARNING: at fs/btrfs/volumes.c:3913 btrfs_map_bio+0x482/0x6c2 [btrfs]()
[<ffffffffa019bbf6>] btrfs_map_bio+0x482/0x6c2 [btrfs]
[<ffffffffa01777c1>] __btree_submit_bio_done+0x16/0x18 [btrfs]
[<ffffffffa0178d2f>] run_one_async_done+0x8d/0x92 [btrfs]
[<ffffffffa019f0c7>] run_ordered_completions+0x73/0xbe [btrfs]
>From a check for !device->bdev in raid56_parity_write().
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2010-04-30 20:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 18:06 Updating RAID[56] support David Woodhouse
2010-04-30 18:39 ` Josef Bacik
2010-04-30 20:00 ` David Woodhouse [this message]
2010-04-30 19:23 ` Roy Sigurd Karlsbakk
2010-05-04 14:55 ` Andrew Dunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272657613.31892.119.camel@macbook.infradead.org \
--to=dwmw2@infradead.org \
--cc=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).