Re: [PATCH 15/16] f2fs: ensure only power of 2 zone sizes are allowed

Jaegeuk Kim
2022-05-03T20:05:46Z

Applied to f2fs tree. Thanks,

On 04/27, Pankaj Raghav wrote:
> From: Luis Chamberlain <mcgrof@kernel.org>
>
> F2FS zoned support has power of 2 zone size assumption in many places
> such as in __f2fs_issue_discard_zone, init_blkz_info. As the power of 2
> requirement has been removed from the block layer, explicitly add a
> condition in f2fs to allow only power of 2 zone size devices.
>
> This condition will be relaxed once those calculation based on power of
> 2 is made generic.
>
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> ---
> fs/f2fs/super.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index f64761a15df7..db79abf30002 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -3685,6 +3685,10 @@ static int init_blkz_info(struct f2fs_sb_info *sbi, int devi)
> return 0;
>
> zone_sectors = bdev_zone_sectors(bdev);
> + if (!is_power_of_2(zone_sectors)) {
> + f2fs_err(sbi, "F2FS does not support non power of 2 zone sizes\n");
> + return -EINVAL;
> + }
>
> if (sbi->blocks_per_blkz && sbi->blocks_per_blkz !=
> SECTOR_TO_BLOCK(zone_sectors))
> --
> 2.25.1