Re: [PATCH 13/16] null_blk: allow non power of 2 zoned devices

Bart Van Assche
2022-05-03T17:01:53Z

On 4/27/22 09:02, Pankaj Raghav wrote:
> diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c
> index c441a4972064..82a62b543782 100644
> --- a/drivers/block/null_blk/main.c
> +++ b/drivers/block/null_blk/main.c
> @@ -1931,8 +1931,8 @@ static int null_validate_conf(struct nullb_device *dev)
> dev->mbps = 0;
>
> if (dev->zoned &&
> - (!dev->zone_size || !is_power_of_2(dev->zone_size))) {
> - pr_err("zone_size must be power-of-two\n");
> + (!dev->zone_size)) {
> + pr_err("zone_size must not be zero\n");
> return -EINVAL;
> }

Please combine "if (dev->zoned &&" and "(!dev->zone_size)) {" into a
single line and leave out the parentheses that became superfluous.

Thanks,

Bart.