From: Josef Bacik <josef@redhat.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH] Btrfs: remove duplicate memset in prepare_pages
Date: Tue, 25 Jan 2011 15:11:13 -0500 [thread overview]
Message-ID: <1295986273-30308-1-git-send-email-josef@redhat.com> (raw)
We already memset the pages array in __btrfs_buffered_write, there's no need to
do it again in prepare_pages.
Signed-off-by: Josef Bacik <josef@redhat.com>
---
fs/btrfs/file.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c
index c0f312a..fd89c5c 100644
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -788,7 +788,6 @@ static noinline int prepare_pages(struct btrfs_root *root, struct file *file,
return err;
}
- memset(pages, 0, num_pages * sizeof(struct page *));
again:
for (i = 0; i < num_pages; i++) {
pages[i] = grab_cache_page(inode->i_mapping, index + i);
--
1.6.6.1
next reply other threads:[~2011-01-25 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 20:11 Josef Bacik [this message]
2011-01-25 22:09 ` [PATCH] Btrfs: fix how we deal with the pages array in the write path Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295986273-30308-1-git-send-email-josef@redhat.com \
--to=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).