linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Rosenberg <drosenberg@vsecurity.com>
To: Josef Bacik <josef@redhat.com>
Cc: chris.mason@oracle.com, security@kernel.org,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@kernel.org
Subject: Re: [PATCH] btrfs: prevent heap corruption in btrfs_ioctl_space_info()
Date: Wed, 09 Feb 2011 11:45:24 -0500	[thread overview]
Message-ID: <1297269924.11434.26.camel@Dan> (raw)
In-Reply-To: <20110209161654.GB2564@localhost.localdomain>


> 
> Argh sorry I take it back, this is wrong, we can have multiple raid types per
> space info, so you need to put the slot_count-- in the inner loop farther down
> to count the actual slots we're adding.  Thanks,
> 

Good catch, thanks.

Reviewed-by: Dan Rosenberg <drosenberg@vsecurity.com>

-Dan


      reply	other threads:[~2011-02-09 16:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-09 14:12 [PATCH] btrfs: prevent heap corruption in btrfs_ioctl_space_info() Dan Rosenberg
2011-02-09 15:51 ` Josef Bacik
2011-02-09 16:16   ` Josef Bacik
2011-02-09 16:45     ` Dan Rosenberg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297269924.11434.26.camel@Dan \
    --to=drosenberg@vsecurity.com \
    --cc=chris.mason@oracle.com \
    --cc=josef@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=security@kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).