From: Dan Rosenberg <drosenberg@vsecurity.com>
To: lizf@cn.fujitsu.com, chris.mason@oracle.com
Cc: linux-btrfs@vger.kernel.org
Subject: btrfs: issues with SUBVOL_SETFLAGS
Date: Wed, 09 Feb 2011 14:14:41 -0500 [thread overview]
Message-ID: <1297278881.11434.36.camel@Dan> (raw)
Commit 0caa102da82799efaba88e234484786a9591c797 introduced the
SUBVOL_SETFLAGS ioctl, which contains the following check:
if (flags & ~BTRFS_SUBVOL_CREATE_ASYNC)
return -EINVAL;
if (flags & ~BTRFS_SUBVOL_RDONLY)
return -EOPNOTSUPP;
Is it intentional that 0 is the only acceptable flags value? In
addition, there should probably be an inode ownership check before
allowing setting subvolume flags.
Regards,
Dan
next reply other threads:[~2011-02-09 19:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-09 19:14 Dan Rosenberg [this message]
2011-02-10 1:34 ` btrfs: issues with SUBVOL_SETFLAGS Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297278881.11434.36.camel@Dan \
--to=drosenberg@vsecurity.com \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).