From: Eduardo Silva <eduardo.silva@oracle.com>
To: Thomas Bellman <bellman@nsc.liu.se>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs-progs use safe string manipulation functions
Date: Thu, 10 Feb 2011 08:49:28 -0300 [thread overview]
Message-ID: <1297338568.28159.8.camel@monotop> (raw)
In-Reply-To: <4D53C711.3000309@nsc.liu.se>
On Thu, 2011-02-10 at 12:08 +0100, Thomas Bellman wrote:
> On 2011-02-07 13:22, Eduardo Silva wrote:
>
> > Please find the attached patch which replace unsafe strcpy(3) by
> > strncpy(3) functions.
>
> strncpy() doesn't NUL-terminate the destination buffer if the
> maximum length is reached. And as far as I can see, there is
> no other initialization of those buffers to zeroes, except for
> super.label in make_btrfs() in utils.c.
>
> So please change those strncpy() calls to something like:
>
> strncpy(args.name, source, BTRFS_PATH_NAME_MAX);
> args.name[BTRFS_PATH_NAME_MAX] = '\0';
>
Seems like a string manipulation function is the way to go, will send a
new patch shortly,
best,
Eduardo
prev parent reply other threads:[~2011-02-10 11:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-07 12:22 [PATCH] Btrfs-progs use safe string manipulation functions Eduardo Silva
2011-02-07 18:17 ` Goffredo Baroncelli
2011-02-10 11:08 ` Thomas Bellman
2011-02-10 11:21 ` Olaf van der Spek
2011-02-10 11:37 ` Jeremy Sanders
2011-02-10 11:39 ` Olaf van der Spek
2011-02-10 13:29 ` Eduardo Silva
2011-02-10 13:34 ` Olaf van der Spek
2011-02-10 13:41 ` Eduardo Silva
[not found] ` <1297345079.28159.14.camel@monotop>
2011-02-10 13:52 ` Olaf van der Spek
2011-02-10 14:00 ` Eduardo Silva
2011-02-10 14:05 ` Olaf van der Spek
2011-02-10 18:39 ` Goffredo Baroncelli
2011-02-11 12:41 ` Lars Wirzenius
2011-02-10 11:54 ` Lars Wirzenius
2011-02-10 12:27 ` Olaf van der Spek
2011-02-10 12:41 ` Thomas Bellman
2011-02-10 15:17 ` Olaf van der Spek
2011-02-10 11:49 ` Eduardo Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297338568.28159.8.camel@monotop \
--to=eduardo.silva@oracle.com \
--cc=bellman@nsc.liu.se \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).