From: Chris Mason <chris.mason@oracle.com>
To: Josef Bacik <josef@redhat.com>
Cc: Marti Raudsepp <marti@juffo.org>,
btrfs hackers <linux-btrfs@vger.kernel.org>,
Kernel hackers <linux-kernel@vger.kernel.org>
Subject: Re: btrfs: compression breaks cp and cross-FS mv, FS_IOC_FIEMAP bug?
Date: Mon, 14 Feb 2011 10:01:47 -0500 [thread overview]
Message-ID: <1297695521-sup-9460@think> (raw)
In-Reply-To: <20110213161329.GL19533@dhcp231-156.rdu.redhat.com>
Excerpts from Josef Bacik's message of 2011-02-13 11:13:30 -0500:
> On Sun, Feb 13, 2011 at 06:07:36PM +0200, Marti Raudsepp wrote:
> > On Sun, Feb 13, 2011 at 17:57, Josef Bacik <josef@redhat.com> wrote:
> > > Does the same problem happen when you use cp --sparse=never?
> >
> > You are right. cp --sparse=never does not cause data loss.
> >
>
> So fiemap probably isn't doing the right thing when compression is enabled,
> which doesn't suprise me since we don't do the right thing with delalloc either.
> I will try and get to this soon. Thanks,
This might be a bug in the cp code. We're setting the disk extent to
zero but setting different flags to say we're inline and compressed.
The cp fiemap code might be ignoring the flags?
Or, it could just be delalloc ;)
-chris
next prev parent reply other threads:[~2011-02-14 15:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 15:49 btrfs: compression breaks cp and cross-FS mv, FS_IOC_FIEMAP bug? Marti Raudsepp
2011-02-13 15:57 ` Josef Bacik
2011-02-13 16:07 ` Marti Raudsepp
2011-02-13 16:13 ` Josef Bacik
2011-02-14 15:01 ` Chris Mason [this message]
2011-02-14 17:58 ` Marti Raudsepp
2011-02-14 18:01 ` Chris Mason
2011-02-15 11:30 ` Pádraig Brady
2011-02-15 13:18 ` Josef Bacik
2011-02-13 16:31 ` Hugo Mills
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297695521-sup-9460@think \
--to=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marti@juffo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).