Re: [PATCH] btrfs-progs: tests: not_run for global_prereq fail

[Anand Jain <anand.jain@oracle.com>]

On 28/07/2023 11:39, Anand Jain wrote:
> On 28/07/2023 00:51, David Sterba wrote:
>> On Tue, Jul 25, 2023 at 05:43:54PM +0800, Anand Jain wrote:
>>> Prerequisite checks using global_prereq() aren't global, so why
>>> fail and stop further test cases? Instead, just don't run them.
>>
>> I'd rather let the whole testsuite run, a missing global prerequisity
>> means the environment is not set up properly, so this fail as intended.
>> If you look what kind of utilities are checked in that way it's eg. dd,
>> mke2fs, chattr, losetup. All are supposed to be available on a common
>> system so it's not expected to fail.
>>
>> If there's some less common utility and a test which could be optional
>> then this should be a special case, which would require a new helper.
> 
> I would prefer using check_global_prereq() to verify all the mandatory
> prerequisites at once.
> 
> If each test case checks for a different binary using
> check_global_prereq() and it fails during that test case, we have to
> restart, which becomes messy.

  Commit 'btrfs-progs: tests: add script to check global prerequisities'
  addressed the messy situation mentioned above.

> The support for mkreiserfs on OL was removed, causing the test case
> to abruptly stop in the middle.

  Is there a way to skip the test cases?