From: Chris Mason <chris.mason@oracle.com>
To: Chris Mason <chris.mason@oracle.com>
Cc: Li Dongyang <lidongyang@novell.com>,
linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH V4 0/4] Btrfs: batched discard support for btrfs
Date: Sun, 27 Mar 2011 21:39:26 -0400 [thread overview]
Message-ID: <1301276330-sup-3755@think> (raw)
In-Reply-To: <1301275766-sup-2625@think>
Excerpts from Chris Mason's message of 2011-03-27 21:30:20 -0400:
> Excerpts from Chris Mason's message of 2011-03-27 14:10:46 -0400:
> > Excerpts from Li Dongyang's message of 2011-03-24 06:24:24 -0400:
> > > Dear list,
> > > This is V4 of batched discard support, now we will get full mapping of
> > > the free space on each device for RAID0/1/10/DUP instead of just a single
> > > stripe length, and tested with xfsstests 251, Thanks.
> >
> > I've pushed this out into the for-linus branch, along with a full merge
> > to 2.6.39 current git.
> >
> > Please take a look and make sure I've merged it correctly.
>
> Hmmm, this was doing mod operations on 64 bit numbers, so it didn't
> compile at all on 32 bit machines. I've fixed it up and pushed the
> result out to for-linus. Please check the math ;)
BTW, I just rebased this so the incremental fix was before merging into
Linus' tree.
-chris
>
> -chris
>
> >
> > Thanks!
> >
> > -chris
> >
> > > Changelog V4:
> > > *make btrfs_map_block() return full mapping.
> > > Changelog V3:
> > > *fix style problems.
> > > *rebase to 2.6.38-rc7.
> > > Changelog V2:
> > > *Check if we have devices support trim before trying to trim the fs, also adjust
> > > minlen according to the discard_granularity.
> > > *Update reserved extent calculations in btrfs_trim_block_group().
> > > *Call cond_resched() without checking need_resched()
> > > *Use bitmap_clear_bits() and unlink_free_space() instead of btrfs_remove_free_space(),
> > > so we won't search the same extent for twice.
> > > *Try harder in btrfs_discard_extent(), now we won't report errors
> > > if it's not a EOPNOTSUPP.
> > > *make sure the block group is cached before trimming it,or we'll see an empty caching
> > > tree if the block group is not cached.
> > > *Minor return value fix in btrfs_discard_block_group().
next prev parent reply other threads:[~2011-03-28 1:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 10:24 [PATCH V4 0/4] Btrfs: batched discard support for btrfs Li Dongyang
2011-03-24 10:24 ` [PATCH V4 1/4] Btrfs: make update_reserved_bytes() public Li Dongyang
2011-03-24 10:24 ` [PATCH V4 2/4] Btrfs: make btrfs_map_block() return entire free extent for each device of RAID0/1/10/DUP Li Dongyang
2011-03-24 10:24 ` [PATCH V4 3/4] Btrfs: adjust btrfs_discard_extent() return errors and trimmed bytes Li Dongyang
2011-03-24 10:24 ` [PATCH V4 4/4] Btrfs: add btrfs_trim_fs() to handle FITRIM Li Dongyang
2011-03-27 18:10 ` [PATCH V4 0/4] Btrfs: batched discard support for btrfs Chris Mason
2011-03-28 1:30 ` Chris Mason
2011-03-28 1:39 ` Chris Mason [this message]
2011-03-28 9:25 ` Li Dongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1301276330-sup-3755@think \
--to=chris.mason@oracle.com \
--cc=lidongyang@novell.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).