linux-btrfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Calvin Walton <calvin.walton@kepstin.ca>
Cc: Josef Bacik <josef@redhat.com>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: Do not use free space caching!
Date: Fri, 01 Apr 2011 14:00:32 -0400	[thread overview]
Message-ID: <1301680812-sup-3527@think> (raw)
In-Reply-To: <1301680612.1934.3.camel@ayu>

Excerpts from Calvin Walton's message of 2011-04-01 13:56:51 -0400:
> On Thu, 2011-03-31 at 18:59 -0400, Josef Bacik wrote:
> > On Thu, Mar 31, 2011 at 05:06:42PM -0400, Calvin Walton wrote:
> > > On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote:
> > > > Hello,
> > > > 
> > > > Just found a big bug in the free space caching stuff that will result in 
> > > > early ENOSPC.  I'm working on fixing this bug, but it won't be until 
> > > > tomorrow that I'll have it completely working, so for now make sure to 
> > > > mount -o clear_cache so that it just clears the cache and doesn't use it.
> > 
> > Yeah it affects any kernel that has the free space cache feature, which I think
> > started in .37.  Course you have to have specifically enabled it, so it's not a
> > huge problem.  I've submitted a patch, but since it's currently an optional
> > feature I don't think it needs to go to stable.  Thanks,
> 
> If you don't think the full fix is appropriate for the stable kernel,
> what about sending a simple patch to stable that just disables the free
> space caching support?
> 
> That should be enough to stop any adventurous users (of the kind who
> don't read mailing lists) from trying the free space caching support,
> and possibly hitting this bug.
> 

We'll have a known stable patch for this shortly, I'd rather do that and
send it back to the stable kernels.

-chris

      reply	other threads:[~2011-04-01 18:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30 21:19 Do not use free space caching! Josef Bacik
2011-03-31 21:06 ` Calvin Walton
2011-03-31 22:59   ` Josef Bacik
2011-04-01 13:27     ` Konstantinos Skarlatos
2011-04-01 17:56     ` Calvin Walton
2011-04-01 18:00       ` Chris Mason [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1301680812-sup-3527@think \
    --to=chris.mason@oracle.com \
    --cc=calvin.walton@kepstin.ca \
    --cc=josef@redhat.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).