* Do not use free space caching!
@ 2011-03-30 21:19 Josef Bacik
2011-03-31 21:06 ` Calvin Walton
0 siblings, 1 reply; 6+ messages in thread
From: Josef Bacik @ 2011-03-30 21:19 UTC (permalink / raw)
To: linux-btrfs
Hello,
Just found a big bug in the free space caching stuff that will result in
early ENOSPC. I'm working on fixing this bug, but it won't be until
tomorrow that I'll have it completely working, so for now make sure to
mount -o clear_cache so that it just clears the cache and doesn't use it.
NOTE: It doesn't cause problems other than early ENOSPC, you won't get
corruption or anything like that, tho you could possibly panic.
Sorry for the inconvenience. Thanks,
Josef
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Do not use free space caching!
2011-03-30 21:19 Do not use free space caching! Josef Bacik
@ 2011-03-31 21:06 ` Calvin Walton
2011-03-31 22:59 ` Josef Bacik
0 siblings, 1 reply; 6+ messages in thread
From: Calvin Walton @ 2011-03-31 21:06 UTC (permalink / raw)
To: Josef Bacik; +Cc: linux-btrfs
On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote:
> Hello,
>
> Just found a big bug in the free space caching stuff that will result in
> early ENOSPC. I'm working on fixing this bug, but it won't be until
> tomorrow that I'll have it completely working, so for now make sure to
> mount -o clear_cache so that it just clears the cache and doesn't use it.
>
> NOTE: It doesn't cause problems other than early ENOSPC, you won't get
> corruption or anything like that, tho you could possibly panic.
>
> Sorry for the inconvenience. Thanks,
Any chance you could provide a little more information about which
kernels are affected? Is it any kernel with free space cache support (is
2.6.38.x included?) - and if so, do you plan on submitting the fix to
the stable kernel series?
--
Calvin Walton <calvin.walton@kepstin.ca>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Do not use free space caching!
2011-03-31 21:06 ` Calvin Walton
@ 2011-03-31 22:59 ` Josef Bacik
2011-04-01 13:27 ` Konstantinos Skarlatos
2011-04-01 17:56 ` Calvin Walton
0 siblings, 2 replies; 6+ messages in thread
From: Josef Bacik @ 2011-03-31 22:59 UTC (permalink / raw)
To: Calvin Walton; +Cc: Josef Bacik, linux-btrfs
On Thu, Mar 31, 2011 at 05:06:42PM -0400, Calvin Walton wrote:
> On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote:
> > Hello,
> >
> > Just found a big bug in the free space caching stuff that will result in
> > early ENOSPC. I'm working on fixing this bug, but it won't be until
> > tomorrow that I'll have it completely working, so for now make sure to
> > mount -o clear_cache so that it just clears the cache and doesn't use it.
> >
> > NOTE: It doesn't cause problems other than early ENOSPC, you won't get
> > corruption or anything like that, tho you could possibly panic.
> >
> > Sorry for the inconvenience. Thanks,
>
> Any chance you could provide a little more information about which
> kernels are affected? Is it any kernel with free space cache support (is
> 2.6.38.x included?) - and if so, do you plan on submitting the fix to
> the stable kernel series?
>
Yeah it affects any kernel that has the free space cache feature, which I think
started in .37. Course you have to have specifically enabled it, so it's not a
huge problem. I've submitted a patch, but since it's currently an optional
feature I don't think it needs to go to stable. Thanks,
Josef
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Do not use free space caching!
2011-03-31 22:59 ` Josef Bacik
@ 2011-04-01 13:27 ` Konstantinos Skarlatos
2011-04-01 17:56 ` Calvin Walton
1 sibling, 0 replies; 6+ messages in thread
From: Konstantinos Skarlatos @ 2011-04-01 13:27 UTC (permalink / raw)
To: Josef Bacik; +Cc: Calvin Walton, linux-btrfs
On 1/4/2011 1:59 =CF=80=CE=BC, Josef Bacik wrote:
> On Thu, Mar 31, 2011 at 05:06:42PM -0400, Calvin Walton wrote:
>> On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote:
>>> Hello,
>>>
>>> Just found a big bug in the free space caching stuff that will resu=
lt in
>>> early ENOSPC. I'm working on fixing this bug, but it won't be unti=
l
>>> tomorrow that I'll have it completely working, so for now make sure=
to
>>> mount -o clear_cache so that it just clears the cache and doesn't u=
se it.
>>>
>>> NOTE: It doesn't cause problems other than early ENOSPC, you won't =
get
>>> corruption or anything like that, tho you could possibly panic.
>>>
>>> Sorry for the inconvenience. Thanks,
>> Any chance you could provide a little more information about which
>> kernels are affected? Is it any kernel with free space cache support=
(is
>> 2.6.38.x included?) - and if so, do you plan on submitting the fix t=
o
>> the stable kernel series?
>>
> Yeah it affects any kernel that has the free space cache feature, whi=
ch I think
> started in .37. Course you have to have specifically enabled it, so =
it's not a
> huge problem. I've submitted a patch, but since it's currently an op=
tional
> feature I don't think it needs to go to stable. Thanks,
So it will have to wait for 2.6.39? If possible please push it for=20
inclusion it in the next stable of 2.6.38, as 2.6.39 is a few months=20
away and i wont risk an early RC for my system
Thanks
> Josef
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs=
" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" =
in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Do not use free space caching!
2011-03-31 22:59 ` Josef Bacik
2011-04-01 13:27 ` Konstantinos Skarlatos
@ 2011-04-01 17:56 ` Calvin Walton
2011-04-01 18:00 ` Chris Mason
1 sibling, 1 reply; 6+ messages in thread
From: Calvin Walton @ 2011-04-01 17:56 UTC (permalink / raw)
To: Josef Bacik; +Cc: linux-btrfs
On Thu, 2011-03-31 at 18:59 -0400, Josef Bacik wrote:
> On Thu, Mar 31, 2011 at 05:06:42PM -0400, Calvin Walton wrote:
> > On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote:
> > > Hello,
> > >
> > > Just found a big bug in the free space caching stuff that will result in
> > > early ENOSPC. I'm working on fixing this bug, but it won't be until
> > > tomorrow that I'll have it completely working, so for now make sure to
> > > mount -o clear_cache so that it just clears the cache and doesn't use it.
>
> Yeah it affects any kernel that has the free space cache feature, which I think
> started in .37. Course you have to have specifically enabled it, so it's not a
> huge problem. I've submitted a patch, but since it's currently an optional
> feature I don't think it needs to go to stable. Thanks,
If you don't think the full fix is appropriate for the stable kernel,
what about sending a simple patch to stable that just disables the free
space caching support?
That should be enough to stop any adventurous users (of the kind who
don't read mailing lists) from trying the free space caching support,
and possibly hitting this bug.
--
Calvin Walton <calvin.walton@kepstin.ca>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Do not use free space caching!
2011-04-01 17:56 ` Calvin Walton
@ 2011-04-01 18:00 ` Chris Mason
0 siblings, 0 replies; 6+ messages in thread
From: Chris Mason @ 2011-04-01 18:00 UTC (permalink / raw)
To: Calvin Walton; +Cc: Josef Bacik, linux-btrfs
Excerpts from Calvin Walton's message of 2011-04-01 13:56:51 -0400:
> On Thu, 2011-03-31 at 18:59 -0400, Josef Bacik wrote:
> > On Thu, Mar 31, 2011 at 05:06:42PM -0400, Calvin Walton wrote:
> > > On Wed, 2011-03-30 at 17:19 -0400, Josef Bacik wrote:
> > > > Hello,
> > > >
> > > > Just found a big bug in the free space caching stuff that will result in
> > > > early ENOSPC. I'm working on fixing this bug, but it won't be until
> > > > tomorrow that I'll have it completely working, so for now make sure to
> > > > mount -o clear_cache so that it just clears the cache and doesn't use it.
> >
> > Yeah it affects any kernel that has the free space cache feature, which I think
> > started in .37. Course you have to have specifically enabled it, so it's not a
> > huge problem. I've submitted a patch, but since it's currently an optional
> > feature I don't think it needs to go to stable. Thanks,
>
> If you don't think the full fix is appropriate for the stable kernel,
> what about sending a simple patch to stable that just disables the free
> space caching support?
>
> That should be enough to stop any adventurous users (of the kind who
> don't read mailing lists) from trying the free space caching support,
> and possibly hitting this bug.
>
We'll have a known stable patch for this shortly, I'd rather do that and
send it back to the stable kernels.
-chris
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-01 18:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-30 21:19 Do not use free space caching! Josef Bacik
2011-03-31 21:06 ` Calvin Walton
2011-03-31 22:59 ` Josef Bacik
2011-04-01 13:27 ` Konstantinos Skarlatos
2011-04-01 17:56 ` Calvin Walton
2011-04-01 18:00 ` Chris Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).