From: Chris Mason <chris.mason@oracle.com>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>, BTRFS <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 1/2] Btrfs: allocate extent state and check the result properly
Date: Tue, 19 Apr 2011 07:55:21 -0400 [thread overview]
Message-ID: <1303213987-sup-4275@think> (raw)
In-Reply-To: <4DACEA40.5020008@cn.fujitsu.com>
Excerpts from Xiao Guangrong's message of 2011-04-18 21:49:52 -0400:
> On 04/12/2011 04:14 PM, Xiao Guangrong wrote:
> > It doesn't allocate extent_state and check the result properly:
> > - in set_extent_bit, it doesn't allocate extent_state if the path is not
> > allowed wait
> >
> > - in clear_extent_bit, it doesn't check the result after atomic-ly allocate,
> > we trigger BUG_ON() if it's fail
> >
> > - if allocate fail, we trigger BUG_ON instead of returning -ENOMEM since
> > the return value of clear_extent_bit() is ignored by many callers
> >
>
> Ping...to see what happened. :-)
Sorry, could you please change this to check the results of the atomic
allocatoin in set/clear_extent_bit? I'd rather not add a new BUG_ON
deeper into the code.
-chris
next prev parent reply other threads:[~2011-04-19 11:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 8:14 [PATCH 1/2] Btrfs: allocate extent state and check the result properly Xiao Guangrong
2011-04-12 8:15 ` [PATCH 2/2] Btrfs: fix unsafe usage of merge_state Xiao Guangrong
2011-04-19 1:49 ` [PATCH 1/2] Btrfs: allocate extent state and check the result properly Xiao Guangrong
2011-04-19 11:55 ` Chris Mason [this message]
2011-04-20 6:49 ` Xiao Guangrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303213987-sup-4275@think \
--to=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoguangrong@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).