From: Stephen Smalley <sds@tycho.nsa.gov>
To: Casey Schaufler <casey@schaufler-ca.com>
Cc: LSM <linux-security-module@vger.kernel.org>, linux-btrfs@vger.kernel.org
Subject: Re: Observed unexpected behavior of BTRFS in d_instantiate
Date: Thu, 28 Apr 2011 09:30:41 -0400 [thread overview]
Message-ID: <1303997441.16286.2.camel@moss-pluto> (raw)
In-Reply-To: <4DB78A4A.1080507@schaufler-ca.com>
On Tue, 2011-04-26 at 20:15 -0700, Casey Schaufler wrote:
>
> I have been tracking down an problem that we've been seeing
> with Smack on top of btrfs and have narrowed it down to a check
> in smack_d_instantiate() that checks to see if the underlying
> filesystem supports extended attributes by looking at
>
> inode->i_op->getxattr
>
> If the filesystem has no entry for getxattr it is assumed that
> it does not support extended attributes. The Smack code clearly
> finds this value to be NULL for btrfs and uses a fallback value.
> Clearly something is amiss, as other code paths clearly find the
> i_op->getxattr function and use it to effect. The btrfs code
> quite obviously includes getxattr functions.
>
> So, what is btrfs up to such that the inode ops does not include
> getxattr when security_d_instantiate is called? I am led to
> understand that SELinux has worked around this, but looking at
> the SELinux code I expect that there is a problem there as well.
>
> Thank you.
kernel version(s)?
reproducer?
--
Stephen Smalley
National Security Agency
next prev parent reply other threads:[~2011-04-28 13:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 3:15 Observed unexpected behavior of BTRFS in d_instantiate Casey Schaufler
2011-04-28 13:30 ` Stephen Smalley [this message]
2011-04-28 17:03 ` Casey Schaufler
2011-04-28 17:13 ` Stephen Smalley
2011-04-28 17:23 ` Stephen Smalley
2011-04-28 17:27 ` Chris Mason
2011-04-28 17:52 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1303997441.16286.2.camel@moss-pluto \
--to=sds@tycho.nsa.gov \
--cc=casey@schaufler-ca.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox