From: Josef Bacik <josef@redhat.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 2/4] Btrfs: don't look at the extent buffer level 3 times in a row
Date: Wed, 11 May 2011 17:35:53 -0400 [thread overview]
Message-ID: <1305149755-4413-2-git-send-email-josef@redhat.com> (raw)
In-Reply-To: <1305149755-4413-1-git-send-email-josef@redhat.com>
We have a bit of debugging in btrfs_search_slot to make sure the level of the
cow block is the same as the original block we were cow'ing. I don't think I've
ever seen this tripped, so kill it. This saves us 2 kmap's per level in our
search. Thanks,
Signed-off-by: Josef Bacik <josef@redhat.com>
---
fs/btrfs/ctree.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index 009bcf7..f7a0a64 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -1672,9 +1672,6 @@ again:
}
cow_done:
BUG_ON(!cow && ins_len);
- if (level != btrfs_header_level(b))
- WARN_ON(1);
- level = btrfs_header_level(b);
p->nodes[level] = b;
if (!p->skip_locking)
--
1.7.2.3
next prev parent reply other threads:[~2011-05-11 21:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-11 21:35 [PATCH 1/4] Btrfs: map the node block when looking for readahead targets Josef Bacik
2011-05-11 21:35 ` Josef Bacik [this message]
2011-05-12 15:42 ` [PATCH 2/4] Btrfs: don't look at the extent buffer level 3 times in a row David Sterba
2011-05-12 19:36 ` Josef Bacik
2011-05-11 21:35 ` [PATCH 3/4] Btrfs: kill BTRFS_I(inode)->block_group Josef Bacik
2011-05-11 21:35 ` [PATCH 4/4] Btrfs: try not to sleep as much when doing slow caching Josef Bacik
2011-06-08 8:21 ` [PATCH 1/4] Btrfs: map the node block when looking for readahead targets Arne Jansen
2011-06-08 13:51 ` Josef Bacik
2011-06-08 14:24 ` Arne Jansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305149755-4413-2-git-send-email-josef@redhat.com \
--to=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).