From: Liu Bo <liubo2009@cn.fujitsu.com>
To: <linux-btrfs@vger.kernel.org>
Cc: <chris.mason@oracle.com>, <josef@redhat.com>,
Liu Bo <liubo2009@cn.fujitsu.com>
Subject: [PATCH 04/11 v2] Btrfs: introduce first sub trans
Date: Thu, 26 May 2011 16:19:19 +0800 [thread overview]
Message-ID: <1306397966-7834-5-git-send-email-liubo2009@cn.fujitsu.com> (raw)
In-Reply-To: <1306397966-7834-1-git-send-email-liubo2009@cn.fujitsu.com>
In multi-thread situations, writeback of a file may span across several
sub transactions, and we need to introduce first_sub_trans to get sub_transid of
the first sub transaction recorded, so that log code can skip file extents which
have been logged or committed into disk.
Signed-off-by: Liu Bo <liubo2009@cn.fujitsu.com>
---
fs/btrfs/btrfs_inode.h | 9 +++++++++
fs/btrfs/inode.c | 13 ++++++++++++-
fs/btrfs/transaction.h | 17 ++++++++++++++++-
3 files changed, 37 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/btrfs_inode.h b/fs/btrfs/btrfs_inode.h
index 57c3bb2..fb5617a 100644
--- a/fs/btrfs/btrfs_inode.h
+++ b/fs/btrfs/btrfs_inode.h
@@ -79,6 +79,15 @@ struct btrfs_inode {
/* sequence number for NFS changes */
u64 sequence;
+ /* used to avoid race of first_sub_trans */
+ spinlock_t sub_trans_lock;
+
+ /*
+ * sub transid of the trans that first modified this inode before
+ * a trans commit or a log sync
+ */
+ u64 first_sub_trans;
+
/*
* transid of the trans_handle that last modified this inode
*/
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inode.c
index 7242ebb..e1e5053 100644
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6574,7 +6574,16 @@ again:
set_page_dirty(page);
SetPageUptodate(page);
- BTRFS_I(inode)->last_trans = root->fs_info->generation;
+ spin_lock(&BTRFS_I(inode)->sub_trans_lock);
+
+ if (BTRFS_I(inode)->first_sub_trans > root->fs_info->sub_generation ||
+ BTRFS_I(inode)->last_trans <= BTRFS_I(inode)->logged_trans ||
+ BTRFS_I(inode)->last_trans <= root->fs_info->last_trans_committed)
+ BTRFS_I(inode)->first_sub_trans = root->fs_info->sub_generation;
+
+ spin_unlock(&BTRFS_I(inode)->sub_trans_lock);
+
+ BTRFS_I(inode)->last_trans = root->fs_info->sub_generation;
BTRFS_I(inode)->last_sub_trans = BTRFS_I(inode)->root->log_transid;
unlock_extent_cached(io_tree, page_start, page_end, &cached_state, GFP_NOFS);
@@ -6768,6 +6777,7 @@ struct inode *btrfs_alloc_inode(struct super_block *sb)
ei->space_info = NULL;
ei->generation = 0;
ei->sequence = 0;
+ ei->first_sub_trans = 0;
ei->last_trans = 0;
ei->last_sub_trans = 0;
ei->logged_trans = 0;
@@ -6791,6 +6801,7 @@ struct inode *btrfs_alloc_inode(struct super_block *sb)
extent_io_tree_init(&ei->io_tree, &inode->i_data, GFP_NOFS);
extent_io_tree_init(&ei->io_failure_tree, &inode->i_data, GFP_NOFS);
mutex_init(&ei->log_mutex);
+ spin_lock_init(&ei->sub_trans_lock);
btrfs_ordered_inode_tree_init(&ei->ordered_tree);
INIT_LIST_HEAD(&ei->i_orphan);
INIT_LIST_HEAD(&ei->delalloc_inodes);
diff --git a/fs/btrfs/transaction.h b/fs/btrfs/transaction.h
index 6dcdd28..d531aea 100644
--- a/fs/btrfs/transaction.h
+++ b/fs/btrfs/transaction.h
@@ -83,7 +83,22 @@ static inline void btrfs_update_inode_block_group(
static inline void btrfs_set_inode_last_trans(struct btrfs_trans_handle *trans,
struct inode *inode)
{
- BTRFS_I(inode)->last_trans = trans->transaction->transid;
+ spin_lock(&BTRFS_I(inode)->sub_trans_lock);
+
+ /*
+ * We have joined in a transaction, so btrfs_commit_transaction will
+ * definitely wait for us and it does not need to add a extra
+ * trans_mutex lock here.
+ */
+ if (BTRFS_I(inode)->first_sub_trans > trans->transid ||
+ BTRFS_I(inode)->last_trans <= BTRFS_I(inode)->logged_trans ||
+ BTRFS_I(inode)->last_trans <=
+ BTRFS_I(inode)->root->fs_info->last_trans_committed)
+ BTRFS_I(inode)->first_sub_trans = trans->transid;
+
+ spin_unlock(&BTRFS_I(inode)->sub_trans_lock);
+
+ BTRFS_I(inode)->last_trans = trans->transid;
BTRFS_I(inode)->last_sub_trans = BTRFS_I(inode)->root->log_transid;
}
--
1.6.5.2
next prev parent reply other threads:[~2011-05-26 8:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-26 8:19 [PATCH 00/11 v2] Btrfs: improve write ahead log with sub transaction Liu Bo
2011-05-26 8:19 ` [PATCH 01/11 v2] Btrfs: introduce sub transaction stuff Liu Bo
2011-05-26 8:19 ` [PATCH 02/11 v2] Btrfs: update block generation if should_cow_block fails Liu Bo
2011-05-26 8:19 ` [PATCH 03/11 v2] Btrfs: modify btrfs_drop_extents API Liu Bo
2011-05-26 8:19 ` Liu Bo [this message]
2011-05-26 8:19 ` [PATCH 05/11 v2] Btrfs: still update inode trans stuff when size remains unchanged Liu Bo
2011-05-26 8:19 ` [PATCH 06/11 v2] Btrfs: improve log with sub transaction Liu Bo
2011-05-26 8:19 ` [PATCH 07/11 v2] Btrfs: add checksum check for log Liu Bo
2011-05-26 8:19 ` [PATCH 08/11 v2] Btrfs: fix a bug of log check Liu Bo
2011-05-26 8:19 ` [PATCH 09/11 v2] Btrfs: kick off useless code Liu Bo
2011-05-26 8:19 ` [PATCH 10/11 v2] Btrfs: deal with EEXIST after iput Liu Bo
2011-05-26 8:19 ` [PATCH 11/11 v2] Btrfs: use the right generation number to read log_root_tree Liu Bo
2011-05-26 8:30 ` [PATCH 00/11 v2] Btrfs: improve write ahead log with sub transaction liubo
2011-06-10 0:40 ` David Sterba
2011-06-10 0:52 ` liubo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306397966-7834-5-git-send-email-liubo2009@cn.fujitsu.com \
--to=liubo2009@cn.fujitsu.com \
--cc=chris.mason@oracle.com \
--cc=josef@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).